Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8288993: Make AwtFramePackTest generic by removing @requires tag #9248

Closed
wants to merge 2 commits into from

Conversation

honkar-jdk
Copy link
Contributor

@honkar-jdk honkar-jdk commented Jun 22, 2022

The following test was changed to generic based on this Review Comment and as the condition frame.getSize() == frame.getPreferredSize() should hold on all platforms when frame.pack() is used.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9248/head:pull/9248
$ git checkout pull/9248

Update a local copy of the PR:
$ git checkout pull/9248
$ git pull https://git.openjdk.org/jdk pull/9248/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9248

View PR using the GUI difftool:
$ git pr show -t 9248

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9248.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 22, 2022

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 22, 2022
@openjdk
Copy link

openjdk bot commented Jun 22, 2022

@honkar-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jun 22, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 22, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 22, 2022

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288993: Make AwtFramePackTest generic by removing @requires tag

Reviewed-by: dmarkov, aivanov, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 75 new commits pushed to the master branch:

  • d4b040f: Merge
  • 7e13cdb: 8289079: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed with "RuntimeException: Test failed"
  • 9c92da5: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing
  • 7ac40f3: 8288983: broken link in com.sun.net.httpserver.SimpleFileServer
  • 20f55ab: 8289044: ARM32: missing LIR_Assembler::cmove metadata type support
  • bdf9902: 8288120: VerifyError with JEP 405 pattern match
  • b0db333: 8288528: broken links in java.desktop
  • 651cbeb: 8288080: (fc) FileChannel::map for MemorySegments should state it always throws UOE
  • 1f9521e: 8287076: Document.normalizeDocument() produces different results
  • a716f79: 8288589: Files.readString ignores encoding errors for UTF-16
  • ... and 65 more: https://git.openjdk.org/jdk/compare/f0804304400f380661a8a06e4c1dad97068fae60...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dmarkov20, @aivanov-jdk, @mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 22, 2022
@honkar-jdk
Copy link
Contributor Author

@dmarkov20 Thank you for reviewing.

@honkar-jdk
Copy link
Contributor Author

@mrserb Just wanted to follow-up and check if you wanted to add anything additional to this PR.

@honkar-jdk
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 27, 2022
@openjdk
Copy link

openjdk bot commented Jun 27, 2022

@honkar-jdk
Your change (at version d4db991) is now ready to be sponsored by a Committer.

@aivanov-jdk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 27, 2022

Going to push as commit 40bf3b1.
Since your change was applied there have been 75 commits pushed to the master branch:

  • d4b040f: Merge
  • 7e13cdb: 8289079: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed with "RuntimeException: Test failed"
  • 9c92da5: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing
  • 7ac40f3: 8288983: broken link in com.sun.net.httpserver.SimpleFileServer
  • 20f55ab: 8289044: ARM32: missing LIR_Assembler::cmove metadata type support
  • bdf9902: 8288120: VerifyError with JEP 405 pattern match
  • b0db333: 8288528: broken links in java.desktop
  • 651cbeb: 8288080: (fc) FileChannel::map for MemorySegments should state it always throws UOE
  • 1f9521e: 8287076: Document.normalizeDocument() produces different results
  • a716f79: 8288589: Files.readString ignores encoding errors for UTF-16
  • ... and 65 more: https://git.openjdk.org/jdk/compare/f0804304400f380661a8a06e4c1dad97068fae60...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 27, 2022
@openjdk openjdk bot closed this Jun 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 27, 2022
@openjdk
Copy link

openjdk bot commented Jun 27, 2022

@aivanov-jdk @honkar-jdk Pushed as commit 40bf3b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants