Skip to content

Conversation

@mcpowers
Copy link
Contributor

@mcpowers mcpowers commented Jun 24, 2022

https://bugs.openjdk.org/browse/JDK-8284851


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284851: Update javax.crypto files to use proper javadoc for mentioned classes

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9282/head:pull/9282
$ git checkout pull/9282

Update a local copy of the PR:
$ git checkout pull/9282
$ git pull https://git.openjdk.org/jdk pull/9282/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9282

View PR using the GUI difftool:
$ git pr show -t 9282

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9282.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2022

👋 Welcome back mcpowers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 24, 2022

@mcpowers The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jun 24, 2022
@mcpowers mcpowers changed the title JDK 8284851 JDK 8284851 Update javax.crypto files to use proper javadoc for mentioned classes Jun 28, 2022
@mcpowers mcpowers marked this pull request as ready for review June 28, 2022 00:22
@TheShermanTanker
Copy link
Contributor

@mcpowers Seems like Skara didn't correctly detect and link the JBS entry. Try renaming your title to just "8284851" and see if that works (It may take a while)

@mcpowers mcpowers changed the title JDK 8284851 Update javax.crypto files to use proper javadoc for mentioned classes JDK-8284851 Update javax.crypto files to use proper javadoc for mentioned classes Jun 28, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 28, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 28, 2022

@mcpowers
Copy link
Contributor Author

mcpowers commented Jun 28, 2022 via email

* it in an AccessControlContext object, which it returns. A sample call is
* the following:
* it in an {@code AccessControlContext} object, which it returns.
A sample call is the following:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing "*"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Good catch.


/**
* Constructs a AEADBadTagException with no detail message.
* Constructs an <code>AEADBadTagException</code> with no detail message.
Copy link
Contributor

@valeriepeng valeriepeng Jun 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using the {@code } as in other files?

Copy link
Contributor Author

@mcpowers mcpowers Jun 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started with java.crypto first, and the first few files I looked at had <code> so I used <code>. I later realized there was a mix of styles. I tried to continue with whatever style a file was using.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using {@code }


/**
* Constructs a AEADBadTagException with the specified
* Constructs an <code>AEADBadTagException</code> with the specified
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, use {@code }?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using {@code }


/**
* Constructs a BadPaddingException with no detail
* Constructs a <code>BadPaddingException</code> with no detail
Copy link
Contributor

@valeriepeng valeriepeng Jun 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use {@code }?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using {@code }


/**
* Constructs a BadPaddingException with the specified
* Constructs a <code>BadPaddingException</code> with the specified
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use {@code }?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using {@code }


/**
* Constant used to initialize cipher to encryption mode.
* Constant used to initialize {@code Cipher} to encryption mode.
Copy link
Contributor

@valeriepeng valeriepeng Jun 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's lower case, we normally just leave it? Not sure what is the criteria for changing this. Is it because these are public static constants, so you prefer more formatting? But then, some have "object" following the {@code Cipher}, and some aren't which looks a bit inconsistent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I'd against making this change, i.e. changing all "cipher" occurrences to "{@code Cipher}". Can we just stick to fixing what's broken?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case the sentence was about initializing a cipher object, so I changed it to {@code Cipher}. If a sentence says "cipher block size" then I tried to leave it alone because it's referring to an algorithm rather than a class or object. I could add "object" after {@code Cipher} if it's not present. That would make it more consistent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, add object afterwards would make it more consistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed: {@code Cipher} object

* underlying InputStream but have been additionally processed by the
* Cipher. The Cipher must be fully initialized before being used by
* a CipherInputStream.
* A <code>CipherInputStream</code> is composed of an <code>InputStream</code>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use {@code }? Applies to the rest of changes of this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using {@code }

* that write() methods first process the data before writing them out
* to the underlying OutputStream. The cipher must be fully
* initialized before being used by a CipherOutputStream.
* A <code>CipherOutputStream</code> is composed of an <code>OutputStream</code>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use {@code } for all of the javadoc in this class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using {@code }

* <code>OutputStream</code> and a <code>Cipher</code>.
* <br>Note: if the specified output stream or cipher is
* null, a NullPointerException may be thrown later when
* <code>null</code>, a NullPointerException may be thrown later when
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add {@code } to NullPointerException also

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using {@code }

* This has the effect of constructing a <code>CipherOutputStream</code>
* using a <code>NullCipher</code>.
* <br>Note: if the specified output stream is <code>null</code>, a
* NullPointerException may be thrown later when it is used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add {@code } to NullPointerException also.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using {@code }


/**
* Sets the mode of this cipher.
* Sets the mode of this {@code Cipher}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in the one in Cipher.java, prefer to leave cipher alone.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we're doing {@code Cipher} object.

*
* @return true if the specified permission is an
* instance of CryptoPermission.
* instance of <code>CryptoPermission</code>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use {@code } for all of the javadoc in this class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using {@code }

Copy link
Contributor

@wangweij wangweij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the java.security part. It spends quite some time and you can see my commenting style keeps changing. Unless debatable, no need to reply.



/**
* Returns the "inherited" AccessControl context. This is the context
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what "AccessControl context" is. Either "access control context" or "{@code AccessControlContext}".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using {@code AccessControlContext}

* This method takes a "snapshot" of the current calling context, which
* includes the current Thread's inherited AccessControlContext and any
* limited privilege scope, and places it in an AccessControlContext object.
* includes the current Thread's inherited {@code AccessControlContext}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Thread" to "thread".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in this file and a couple of others.

* getPermission method of the AccessControlException returns the
* {@code perm} Permission object instance.
* {@code getPermission} method of the AccessControlException returns the
* {@code perm} {@code Permission} object instance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two "{@code" together. Maybe move "{@code perm}" to the end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to end.

* the current AccessControlContext and security policy.
* the current {@code AccessControlContext} and security policy.
* This method quietly returns if the access request
* is permitted, or throws an AccessControlException otherwise. The
Copy link
Contributor

@wangweij wangweij Jun 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to code-ify "AccessControlException" as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

* AlgorithmParameterGeneratorSpi implementation from the first
* A new {@code AlgorithmParameterGenerator} object encapsulating the
* {@code AlgorithmParameterGeneratorSpi} implementation from the first
* Provider that supports the specified algorithm is returned.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Provider" -> "provider".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

* Returns a Set of Strings containing the names of all available
* algorithms or types for the specified Java cryptographic service
* (e.g., Signature, MessageDigest, Cipher, Mac, KeyStore). Returns
* an empty Set if there is no provider that supports the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"set" is OK.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

* (e.g., Signature, MessageDigest, Cipher, Mac, KeyStore). Returns
* an empty Set if there is no provider that supports the
* specified service or if serviceName is null. For a complete list
* specified service or if serviceName is {@code null}. For a complete list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{@code serviceName}.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

/**
* Returns a Set of Strings containing the names of all available
* algorithms or types for the specified Java cryptographic service
* (e.g., Signature, MessageDigest, Cipher, Mac, KeyStore). Returns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these Java cryptographic service type names.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using {@code }

* Thus, an {@code UnresolvedPermission} is essentially a "placeholder"
* containing information about the permission.
*
* <p>Later, when code calls AccessController.checkPermission
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AccessController.checkPermission. Maybe make it a link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made it a link

* @param obj the object we are testing for equality with this object.
*
* @return true if obj is an UnresolvedPermission, and has the same
* @return true if obj is an {@code UnresolvedPermission}, and has the same
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{@code obj}.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

* Returns a string describing this CryptoPermission. The convention is to
* specify the class name, the algorithm name, the maximum allowable
* key size, and the name of the exemption mechanism, in the following
* Returns a string describing this {@code CryptoPermission}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add object here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

* A CryptoPermissionCollection stores a set of CryptoPermission
* permissions.
* A {@code CryptoPermissionCollection} stores a set of
* {@code CryptoPermission} permissions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use objects instead of permissions for consistency's sake?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

* format: '("ClassName" "algorithm" "keysize" "exemption_mechanism")'.
*
* @return information about this CryptoPermission.
* @return information about this {@code CryptoPermission}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add object here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

/**
* A CryptoPermissionCollection stores a set of CryptoPermission
* permissions.
* A {@code CryptoPermissionCollection} stores a set of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add object here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.


/**
* Adds a permission to the CryptoPermissionCollection.
* Adds a permission to the {@code CryptoPermissionCollection}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add object here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

*
* @return true if the given permission is implied by this
* CryptoPermissionCollection, false if not.
* @return {@code true} if the given permission is implied by this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant space between permission and is?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

/**
* This class contains CryptoPermission objects, organized into
* This class contains {@code CryptoPermission} objects, organized into
* PermissionCollections according to algorithm names.
Copy link
Contributor

@valeriepeng valeriepeng Jul 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no PermissionCollections class. So, this should probably be changed to "{@code PermissionCollection} objects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

/**
* Populates the crypto policy from the specified
* InputStream into this CryptoPermissions object.
* InputStream into this {@code CryptoPermissions} object.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add {@code } to InputStream?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

* @param permission the Permission object to check.
* @param permission the {@code Permission} object to check.
*
* @return true if "permission" is implied by the permissions
Copy link
Contributor

@valeriepeng valeriepeng Jul 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be {@code permission} instead of "permission". Also, add {@code } to true.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

*
* @return true if "permission" is implied by the permissions
* in the PermissionCollection it belongs to, false if not.
* in the {@code PermissionCollection} it belongs to, false if not.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add {@code } to false.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

*
* @return an enumeration of all the Permissions.
* Returns an enumeration of all the {@code Permission} objects
* in all the PermissionCollections in this
Copy link
Contributor

@valeriepeng valeriepeng Jul 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no PermissionCollections class. So, this should probably be changed to {@code PermissionCollection} objects. However, the sentence seems long and a bit hard to parse. Do you think we really need the middle part, i.e. "in all the PermissionCollection objects"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the middle part. Nothing is lost by removing it.

Comment on lines +95 to +96
* Processes {@code input.remaining()} bytes in the ByteBuffer
* {@code input}, starting at {@code input.position()}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, should these be {@code input}.remaining() and {@code input}.position()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.

* confidentiality with a cryptographic algorithm.
*
* <p> Given any Serializable object, one can create a SealedObject
* <p> Given any Serializable object, one can create a {@code SealedObject}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add {@code } to Serializable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

* encoded in the default format.
* <p>
* That is, <code>cipher.getParameters().getEncoded()</code>.
* That is, {@code cipher.getParameters().getEncoded()}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cipher -> Cipher?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.


/**
* Constructs a SealedObject from any Serializable object.
* Constructs a {@code SealedObject} from any Serializable object.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add {@code } to Serializable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

/**
* Constructs a SealedObject object from the passed-in SealedObject.
* Constructs a <code>SealedObject</code> object from the passed-in
* SealedObject.
Copy link
Contributor

@valeriepeng valeriepeng Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the SealedObject on line 195?

* the sealing operation.
* If the default provider package provides an implementation of that
* algorithm, an instance of Cipher containing that implementation is used.
* algorithm, an instance of {@code Cipher} object containing that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"an instance of" seems redundant now that you added "object"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

* @return a new PermissionCollection object suitable for
* storing CryptoAllPermissions.
* @return a new {@code PermissionCollection} object suitable for
* storing {@code CryptoAllPermissions} objects.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: CryptoAllPermissions -> CryptoAllPermission?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.


/**
* Create an empty CryptoAllPermissions object.
* Create an empty {@code CryptoAllPermission} object.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: CryptoAllPermissions -> CryptoAllPermission?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already fixed.

Copy link
Contributor

@valeriepeng valeriepeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with the changes under javax.crypto package.

@mcpowers
Copy link
Contributor Author

mcpowers commented Jul 7, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 7, 2022
@openjdk
Copy link

openjdk bot commented Jul 7, 2022

@mcpowers
Your change (at version cd390f9) is now ready to be sponsored by a Committer.

@valeriepeng
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 7, 2022

Going to push as commit f804f2c.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 8cdead0: 8278923: Document Klass::is_loader_alive
  • f93beac: 8252329: runtime/LoadClass/TestResize.java timed out
  • 3e60e82: 8289301: P11Cipher should not throw out of bounds exception during padding
  • f7b1830: 8289538: Make G1BlockOffsetTablePart unaware of block sizes
  • 5564eff: 8289763: Remove NULL check in CDSProtectionDomain::init_security_info()
  • a694e9e: 8288838: jpackage: file association additional arguments
  • 95e3190: 8210708: Use single mark bitmap in G1
  • 8e7b45b: 8282986: Remove "system" in boot class path names
  • 74ca6ca: 8289800: G1: G1CollectionSet::finalize_young_part clears survivor list too early
  • 86f63f9: 8289164: Convert ResolutionErrorTable to use ResourceHashtable
  • ... and 8 more: https://git.openjdk.org/jdk/compare/403a9bc79645018ee61b47bab67fe231577dd914...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 7, 2022
@openjdk openjdk bot closed this Jul 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 7, 2022
@openjdk
Copy link

openjdk bot commented Jul 7, 2022

@valeriepeng @mcpowers Pushed as commit f804f2c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mcpowers mcpowers deleted the JDK-8284851 branch July 9, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

5 participants