Skip to content

Conversation

@coleenp
Copy link
Contributor

@coleenp coleenp commented Jul 6, 2022

This trivial change just adds a comment to Klass::is_loader_alive.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9400/head:pull/9400
$ git checkout pull/9400

Update a local copy of the PR:
$ git checkout pull/9400
$ git pull https://git.openjdk.org/jdk pull/9400/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9400

View PR using the GUI difftool:
$ git pr show -t 9400

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9400.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 6, 2022

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 6, 2022
@openjdk
Copy link

openjdk bot commented Jul 6, 2022

@coleenp The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jul 6, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 6, 2022

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

Thanks.

@coleenp
Copy link
Contributor Author

coleenp commented Jul 7, 2022

Thank you David!

@openjdk
Copy link

openjdk bot commented Jul 7, 2022

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278923: Document Klass::is_loader_alive

Reviewed-by: dholmes, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 84 new commits pushed to the master branch:

  • a694e9e: 8288838: jpackage: file association additional arguments
  • 95e3190: 8210708: Use single mark bitmap in G1
  • 8e7b45b: 8282986: Remove "system" in boot class path names
  • 74ca6ca: 8289800: G1: G1CollectionSet::finalize_young_part clears survivor list too early
  • 86f63f9: 8289164: Convert ResolutionErrorTable to use ResourceHashtable
  • 013a5ee: 8137280: Remove eager reclaim of humongous controls
  • 77ad998: 8289778: ZGC: incorrect use of os::free() for mountpoint string handling after JDK-8289633
  • 532a6ec: 7124313: [macosx] Swing Popups should overlap taskbar
  • e05b2f2: 8289856: [PPC64] SIGSEGV in C2Compiler::init_c2_runtime() after JDK-8289060
  • cce77a7: 8289799: Build warning in methodData.cpp memset zero-length parameter
  • ... and 74 more: https://git.openjdk.org/jdk/compare/feb223aacfd89d598a27b27c4b8be4601cc5eaff...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 7, 2022
Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coleenp
Copy link
Contributor Author

coleenp commented Jul 7, 2022

Thanks Ioi!
/integrate

@openjdk
Copy link

openjdk bot commented Jul 7, 2022

Going to push as commit 8cdead0.
Since your change was applied there have been 88 commits pushed to the master branch:

  • f93beac: 8252329: runtime/LoadClass/TestResize.java timed out
  • 3e60e82: 8289301: P11Cipher should not throw out of bounds exception during padding
  • f7b1830: 8289538: Make G1BlockOffsetTablePart unaware of block sizes
  • 5564eff: 8289763: Remove NULL check in CDSProtectionDomain::init_security_info()
  • a694e9e: 8288838: jpackage: file association additional arguments
  • 95e3190: 8210708: Use single mark bitmap in G1
  • 8e7b45b: 8282986: Remove "system" in boot class path names
  • 74ca6ca: 8289800: G1: G1CollectionSet::finalize_young_part clears survivor list too early
  • 86f63f9: 8289164: Convert ResolutionErrorTable to use ResourceHashtable
  • 013a5ee: 8137280: Remove eager reclaim of humongous controls
  • ... and 78 more: https://git.openjdk.org/jdk/compare/feb223aacfd89d598a27b27c4b8be4601cc5eaff...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 7, 2022
@openjdk openjdk bot closed this Jul 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 7, 2022
@openjdk
Copy link

openjdk bot commented Jul 7, 2022

@coleenp Pushed as commit 8cdead0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp coleenp deleted the names branch July 7, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants