Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290065: [JVMCI] only check HotSpotCompiledCode stream is empty if installation succeeds #9446

Closed
wants to merge 1 commit into from

Conversation

dougxc
Copy link
Member

@dougxc dougxc commented Jul 11, 2022

Decoding the HotSpotCompiledCode stream (see JDK-8289094) can be short circuited if certain limits are encountered such as the code cache being full or JVMCINMethodSizeLimit being exceeded.
This PR omits the check that the complete stream has been read should be emitted if such a limit is hit.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290065: [JVMCI] only check HotSpotCompiledCode stream is empty if installation succeeds

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9446/head:pull/9446
$ git checkout pull/9446

Update a local copy of the PR:
$ git checkout pull/9446
$ git pull https://git.openjdk.org/jdk pull/9446/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9446

View PR using the GUI difftool:
$ git pr show -t 9446

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9446.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 11, 2022

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 11, 2022

@dougxc The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jul 11, 2022
@dougxc dougxc marked this pull request as ready for review July 11, 2022 09:04
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 11, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 11, 2022

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and trivial.

@openjdk
Copy link

openjdk bot commented Jul 11, 2022

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290065: [JVMCI] only check HotSpotCompiledCode stream is empty if installation succeeds

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • c79baaa: Merge
  • cb6e9cb: 8290004: [PPC64] JfrGetCallTrace: assert(_pc != nullptr) failed: must have PC
  • 0494291: 8289692: JFR: Thread checkpoint no longer enforce mutual exclusion post Loom integration
  • 25f4b04: 8289894: A NullPointerException thrown from guard expression
  • b542bcb: 8289729: G1: Incorrect verification logic in G1ConcurrentMark::clear_next_bitmap
  • c86c51c: 8282071: Update java.xml module-info
  • 9981c85: 8290033: ProblemList serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java on windows-x64 in -Xcomp mode
  • c142fbb: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad
  • eeaf0bb: 8289872: wrong wording in @param doc for HashMap.newHashMap et. al.
  • 460d879: 8289601: SegmentAllocator::allocateUtf8String(String str) should be clarified for strings containing \0
  • ... and 14 more: https://git.openjdk.org/jdk/compare/0225eb434cb8792d362923bf2c2e3607be4efcb9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 11, 2022
@dougxc
Copy link
Member Author

dougxc commented Jul 11, 2022

Thanks for the review @vnkozlov .

@dougxc
Copy link
Member Author

dougxc commented Jul 11, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jul 11, 2022

Going to push as commit 21db9a5.
Since your change was applied there have been 24 commits pushed to the master branch:

  • c79baaa: Merge
  • cb6e9cb: 8290004: [PPC64] JfrGetCallTrace: assert(_pc != nullptr) failed: must have PC
  • 0494291: 8289692: JFR: Thread checkpoint no longer enforce mutual exclusion post Loom integration
  • 25f4b04: 8289894: A NullPointerException thrown from guard expression
  • b542bcb: 8289729: G1: Incorrect verification logic in G1ConcurrentMark::clear_next_bitmap
  • c86c51c: 8282071: Update java.xml module-info
  • 9981c85: 8290033: ProblemList serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java on windows-x64 in -Xcomp mode
  • c142fbb: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad
  • eeaf0bb: 8289872: wrong wording in @param doc for HashMap.newHashMap et. al.
  • 460d879: 8289601: SegmentAllocator::allocateUtf8String(String str) should be clarified for strings containing \0
  • ... and 14 more: https://git.openjdk.org/jdk/compare/0225eb434cb8792d362923bf2c2e3607be4efcb9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 11, 2022
@openjdk openjdk bot closed this Jul 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 11, 2022
@openjdk
Copy link

openjdk bot commented Jul 11, 2022

@dougxc Pushed as commit 21db9a5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dougxc dougxc deleted the JDK-8290065 branch May 23, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants