Skip to content

Conversation

@iklam
Copy link
Member

@iklam iklam commented Jul 15, 2022

Please remove this trivial change. Although many files are changed, I am only removing unused files and changing a couple of comments.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9506/head:pull/9506
$ git checkout pull/9506

Update a local copy of the PR:
$ git checkout pull/9506
$ git pull https://git.openjdk.org/jdk pull/9506/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9506

View PR using the GUI difftool:
$ git pr show -t 9506

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9506.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 15, 2022

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 15, 2022

@iklam The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jul 15, 2022
@iklam iklam marked this pull request as ready for review July 15, 2022 05:44
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 15, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 15, 2022

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine and trivial.

Thanks.

@openjdk
Copy link

openjdk bot commented Jul 15, 2022

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290333: Remove os_share_*.hpp

Reviewed-by: dholmes, jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 0184f46: 8289919: [test] LoadLibraryUnloadTest.java failed with "Failed to unload native library"
  • cca91f7: 8290327: Remove java/lang/reflect/callerCache/ReflectionCallerCacheTest.java from ProblemList-Xcomp.txt
  • b4e2ce0: 8290366: Remove unused during_conc_mark parameter in HeapRegion::note_self_forwarding_removal_start
  • f3abb82: 8268312: Compilation error with nested generic functional interface
  • 92deab5: 8028265: Add legacy tz tests to OpenJDK
  • 70fce07: 8290246: test fails "assert(init != __null) failed: initialization not found"
  • 757a742: 8290177: Improve documentation in G1MMUTracker
  • 890bced: 8290264: java/util/concurrent/locks/Lock/OOMEInAQS.java fails with "exit code: 0"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 15, 2022
@iklam
Copy link
Member Author

iklam commented Jul 16, 2022

Thanks to @dholmes-ora and @DamonFool for the review.
/integrate

@openjdk
Copy link

openjdk bot commented Jul 16, 2022

Going to push as commit 0143cf1.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 0184f46: 8289919: [test] LoadLibraryUnloadTest.java failed with "Failed to unload native library"
  • cca91f7: 8290327: Remove java/lang/reflect/callerCache/ReflectionCallerCacheTest.java from ProblemList-Xcomp.txt
  • b4e2ce0: 8290366: Remove unused during_conc_mark parameter in HeapRegion::note_self_forwarding_removal_start
  • f3abb82: 8268312: Compilation error with nested generic functional interface
  • 92deab5: 8028265: Add legacy tz tests to OpenJDK
  • 70fce07: 8290246: test fails "assert(init != __null) failed: initialization not found"
  • 757a742: 8290177: Improve documentation in G1MMUTracker
  • 890bced: 8290264: java/util/concurrent/locks/Lock/OOMEInAQS.java fails with "exit code: 0"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 16, 2022
@openjdk openjdk bot closed this Jul 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 16, 2022
@openjdk
Copy link

openjdk bot commented Jul 16, 2022

@iklam Pushed as commit 0143cf1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants