Conversation
|
👋 Welcome back iklam! A progress list of the required criteria for merging this PR into |
Webrevs
|
dholmes-ora
left a comment
There was a problem hiding this comment.
Looks fine and trivial.
Thanks.
|
@iklam This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
Thanks to @dholmes-ora and @DamonFool for the review. |
|
Going to push as commit 0143cf1.
Your commit was automatically rebased without conflicts. |
Please remove this trivial change. Although many files are changed, I am only removing unused files and changing a couple of comments.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9506/head:pull/9506$ git checkout pull/9506Update a local copy of the PR:
$ git checkout pull/9506$ git pull https://git.openjdk.org/jdk pull/9506/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9506View PR using the GUI difftool:
$ git pr show -t 9506Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9506.diff