8269795: C2: Out of bounds array load floats above its range check in loop peeling resulting in SEGV

[TheRealMDoerr]

Backport of JDK-8269795. Doesn't apply cleanly because cleanup change JDK-8223142 is not it 11u. Taken new PhaseIdealLoop::peeled_dom_test_elim which includes the cleanup. Removed key "randomness" from test which doesn't work with 11u.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8269795: C2: Out of bounds array load floats above its range check in loop peeling resulting in SEGV

Reviewers

• Roland Westrelin (@rwestrel - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/166/head:pull/166
$ git checkout pull/166

Update a local copy of the PR:
$ git checkout pull/166
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/166/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 166

View PR using the GUI difftool:
$ git pr show -t 166

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/166.diff

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (0ce1a2a8)

[rwestrel]

Looks good to me.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8269795: C2: Out of bounds array load floats above its range check in loop peeling resulting in SEGV

Reviewed-by: roland

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 57a7e71: 8194230: jdk/internal/jrtfs/remote/RemoteRuntimeImageTest.java fails with java.lang.NullPointerException
• adcfbd2: 8208227: tools/jdeps/DotFileTest.java fails on Win-X64
• 5c8a0b4: 8207316: java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java failed
• 8ec02f3: 8252648: Shenandoah: name gang tasks consistently
• eaf59e0: 8256215: Shenandoah: re-organize saving/restoring machine state in assembler code

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TheRealMDoerr]

Thanks for the review!
/integrate

[openjdk]

Going to push as commit 6e60332.
Since your change was applied there have been 11 commits pushed to the master branch:

• 69697b3: 8208363: test/jdk/java/lang/Package/PackageFromManifest.java missing module dependencies declaration
• 95c94ae: 8209773: Refactor shell test javax/naming/module/basic.sh to java
• d7e852c: 8209930: Refactor java/util/zip/ZipFile/deletetempjar.sh to plain java test
• bb15820: 8042902: Test java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java fails intermittently
• 69341be: 8261147: C2: Node is wrongly marked as reduction resulting in a wrong execution due to wrong vector instructions
• feee8ef: 8209832: Refactor jdk/internal/reflect/Reflection/GetCallerClassTest.sh to plain java test
• 57a7e71: 8194230: jdk/internal/jrtfs/remote/RemoteRuntimeImageTest.java fails with java.lang.NullPointerException
• adcfbd2: 8208227: tools/jdeps/DotFileTest.java fails on Win-X64
• 5c8a0b4: 8207316: java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java failed
• 8ec02f3: 8252648: Shenandoah: name gang tasks consistently
• ... and 1 more: https://git.openjdk.java.net/jdk11u-dev/compare/f700d37d2b3d8c23d50defc19853c68bb60027ab...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit 6e60332.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.