-
Notifications
You must be signed in to change notification settings - Fork 253
8211055: Provide print to a file (PDF) feature even when printer was not connected #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
RealCLanger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - did you run/verify the testcase? It is a manual test which is not covered in our nightlies.
|
@TheRealMDoerr This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
Thanks for the review! The manual test has passed. |
|
Going to push as commit d900e31.
Your commit was automatically rebased without conflicts. |
|
@TheRealMDoerr Pushed as commit d900e31. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of JDK-8211055. Doesn't apply cleanly because JNF removal is already backported to 11u.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/177/head:pull/177$ git checkout pull/177Update a local copy of the PR:
$ git checkout pull/177$ git pull https://git.openjdk.java.net/jdk11u-dev pull/177/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 177View PR using the GUI difftool:
$ git pr show -t 177Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/177.diff