Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8211055: Provide print to a file (PDF) feature even when printer was not connected #177

Closed

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Aug 2, 2021

Backport of JDK-8211055. Doesn't apply cleanly because JNF removal is already backported to 11u.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8211055: Provide print to a file (PDF) feature even when printer was not connected

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/177/head:pull/177
$ git checkout pull/177

Update a local copy of the PR:
$ git checkout pull/177
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/177/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 177

View PR using the GUI difftool:
$ git pr show -t 177

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/177.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 2, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9b0d241a16b2f2abb821c7a74408b826db75ec4a 8211055: Provide print to a file (PDF) feature even when printer was not connected Aug 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 2, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Aug 2, 2021
@TheRealMDoerr TheRealMDoerr marked this pull request as ready for review Aug 3, 2021
@openjdk openjdk bot added the rfr label Aug 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 3, 2021

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

LGTM - did you run/verify the testcase? It is a manual test which is not covered in our nightlies.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 3, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8211055: Provide print to a file (PDF) feature even when printer was not connected

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 815d3e1: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type
  • 4da3fb8: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 3, 2021
@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Aug 4, 2021

Thanks for the review! The manual test has passed.
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

Going to push as commit d900e31.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 7751352: 8230808: Remove Access::equals()
  • 35fcac6: 8168304: Make all of DependencyContext_test available in product mode
  • cf2cf25: 8266761: AssertionError in sun.net.httpserver.ServerImpl.responseCompleted
  • 0c783b0: 8257497: Update keytool to create AKID from the SKID of the issuing certificate as specified by RFC 5280
  • aebdee3: 8230674: Heap dumps should exclude dormant CDS archived objects of unloaded classes
  • 815d3e1: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type
  • 4da3fb8: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 4, 2021
@openjdk openjdk bot added the integrated label Aug 4, 2021
@TheRealMDoerr TheRealMDoerr deleted the 8211055_macos_printer branch Aug 4, 2021
@openjdk openjdk bot removed ready rfr labels Aug 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 4, 2021

@TheRealMDoerr Pushed as commit d900e31.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants