Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321408: Add Certainly roots R1 and E1 #2542

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 22, 2024

I backport this for parity with 11.0.23-oracle.

I had to fix CAInterop to use proper switch syntax and trivialy resolve the other test.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8321408 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321408: Add Certainly roots R1 and E1 (Enhancement - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2542/head:pull/2542
$ git checkout pull/2542

Update a local copy of the PR:
$ git checkout pull/2542
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2542/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2542

View PR using the GUI difftool:
$ git pr show -t 2542

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2542.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 22, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e8f7eaeefe503a34089fd49051f9114d98a63cb1 8321408: Add Certainly roots R1 and E1 Feb 22, 2024
@openjdk
Copy link

openjdk bot commented Feb 22, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Feb 22, 2024
Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. jcheck fails with whitespace, though.

@GoeLin
Copy link
Member Author

GoeLin commented Feb 23, 2024

Thanks for the review!
Tests were green except for the whitespace issue

@openjdk
Copy link

openjdk bot commented Feb 23, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 23, 2024
@openjdk
Copy link

openjdk bot commented Feb 23, 2024

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8321408: Add Certainly roots R1 and E1

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 43a56c8: 8307299: Move more DnD tests to open
  • fe8c20c: 8306681: Open source more AWT DnD related tests
  • 30dfe81: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 23, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 23, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Feb 23, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Feb 23, 2024

Going to push as commit 6711fc8.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 43a56c8: 8307299: Move more DnD tests to open
  • fe8c20c: 8306681: Open source more AWT DnD related tests
  • 30dfe81: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 23, 2024
@openjdk openjdk bot closed this Feb 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 23, 2024
@openjdk
Copy link

openjdk bot commented Feb 23, 2024

@GoeLin Pushed as commit 6711fc8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8321408 branch February 23, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants