8380959: Update Libpng to 1.6.56#116
Conversation
|
👋 Welcome back avieiro! A progress list of the required criteria for merging this PR into |
|
@vieiro This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
Full GHA tests here: https://github.com/vieiro/jdk11u-dev/actions/runs/23813024303 |
|
The full GHA tests passed but on macos, but that's unrelated: GHA bumped clang to 17, something we should fix in |
gnu-andrew
left a comment
There was a problem hiding this comment.
As with 17u, looks mostly clean bar copyright header and context differences in the Makefile. Testing looks good.
|
|
Ok, I guess running on |
Yep, but looks like his stopped working on 2026-03-20. |
|
/approval request Please consider approving this backport from JDK17u that bumps libpng to the latest version, on par with highter JDK versions. Tested on Fedora/Windows 10 and RHEL-8. Relevant tests pass. |
|
/approve yes |
|
@gnu-andrew |
|
/integrate |
|
Going to push as commit 57b1881. |
Mostly clean backport of JDK-8380959 from 17u, that makes 11u libpng on par with the upper JDK versions. It would be great if this could make it for the April CPU.
Backport is not clean because of the differences in
make/lib/Awt2dLibraries.gmkfrom JDK17.Tested on both
Fedora 42/gcc 15.2.1andWindows 10/Visual Studio 2022andRHEL-8with the following tests:Let's see how this builds on GHA's Visual Studio version, though.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u.git pull/116/head:pull/116$ git checkout pull/116Update a local copy of the PR:
$ git checkout pull/116$ git pull https://git.openjdk.org/jdk11u.git pull/116/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 116View PR using the GUI difftool:
$ git pr show -t 116Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/116.diff
Using Webrev
Link to Webrev Comment