Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

8270491: SEGV at read_string_field(oopDesc*, char const*, JavaThread*)+0x54 #261

Closed
wants to merge 1 commit into from

Conversation

mgronlun
Copy link
Contributor

@mgronlun mgronlun commented Jul 21, 2021

Greetings,

Please help review this changeset which adds missing logic to handle potential exceptions when retrieving the MBean argument descriptors for the JFR diagnostic commands.

Testing: jdk_jfr, perfstartup

Thanks
Markus


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270491: SEGV at read_string_field(oopDesc*, char const*, JavaThread*)+0x54

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/261/head:pull/261
$ git checkout pull/261

Update a local copy of the PR:
$ git checkout pull/261
$ git pull https://git.openjdk.java.net/jdk17 pull/261/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 261

View PR using the GUI difftool:
$ git pr show -t 261

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/261.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2021

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 21, 2021
@openjdk
Copy link

openjdk bot commented Jul 21, 2021

@mgronlun The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.java.net label Jul 21, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 21, 2021

Webrevs

@mgronlun
Copy link
Contributor Author

/label remove hotspot-jfr

@openjdk openjdk bot removed the hotspot-jfr hotspot-jfr-dev@openjdk.java.net label Jul 22, 2021
@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@mgronlun
The hotspot-jfr label was successfully removed.

@mgronlun
Copy link
Contributor Author

/label add hotspot-jfr

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.java.net label Jul 22, 2021
@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@mgronlun
The hotspot-jfr label was successfully added.

@mgronlun mgronlun closed this Jul 22, 2021
@mgronlun mgronlun deleted the 8270491 branch July 22, 2021 08:47
@mgronlun mgronlun restored the 8270491 branch July 22, 2021 08:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.java.net rfr Pull request is ready for review
1 participant