This repository was archived by the owner on Sep 2, 2022. It is now read-only.
8270491: SEGV at read_string_field(oopDesc*, char const*, JavaThread*)+0x54#261
Closed
mgronlun wants to merge 1 commit intoopenjdk:masterfrom
Closed
8270491: SEGV at read_string_field(oopDesc*, char const*, JavaThread*)+0x54#261mgronlun wants to merge 1 commit intoopenjdk:masterfrom
mgronlun wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into |
Contributor
Author
|
/label remove hotspot-jfr |
|
@mgronlun |
Contributor
Author
|
/label add hotspot-jfr |
|
@mgronlun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings,
Please help review this changeset which adds missing logic to handle potential exceptions when retrieving the MBean argument descriptors for the JFR diagnostic commands.
Testing: jdk_jfr, perfstartup
Thanks
Markus
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/261/head:pull/261$ git checkout pull/261Update a local copy of the PR:
$ git checkout pull/261$ git pull https://git.openjdk.java.net/jdk17 pull/261/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 261View PR using the GUI difftool:
$ git pr show -t 261Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/261.diff