Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java #1036

Closed
wants to merge 1 commit into from

Conversation

xpbob
Copy link

@xpbob xpbob commented Jan 5, 2023

Backport 5b5552ff2a5fccaa9a34886d9df4c0075fc8f5e8


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/1036/head:pull/1036
$ git checkout pull/1036

Update a local copy of the PR:
$ git checkout pull/1036
$ git pull https://git.openjdk.org/jdk17u-dev pull/1036/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1036

View PR using the GUI difftool:
$ git pr show -t 1036

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1036.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2023

👋 Welcome back xpbob! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5b5552ff2a5fccaa9a34886d9df4c0075fc8f5e8 8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java Jan 5, 2023
@openjdk
Copy link

openjdk bot commented Jan 5, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 5, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2023

Webrevs

@xpbob xpbob closed this Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
1 participant