Skip to content

8307572: AArch64: Vector registers are clobbered by some macroassemblers #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

nsjian
Copy link

@nsjian nsjian commented May 30, 2023

Clean backport of JDK-8307572 to fix a hidden aarch64 issue, which may cause incorrect result with several common intrinsics used. Test case included in the patch failed without the fix and passed with this patch. No new jtreg test failure with both release and fastdebug build.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307572: AArch64: Vector registers are clobbered by some macroassemblers (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1406/head:pull/1406
$ git checkout pull/1406

Update a local copy of the PR:
$ git checkout pull/1406
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1406/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1406

View PR using the GUI difftool:
$ git pr show -t 1406

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1406.diff

Webrev

Link to Webrev Comment

Clean backport of JDK-8307572. Fixes a hidden aarch64 issue, which may
cause incorrect result with several common intrinsics used.
@bridgekeeper
Copy link

bridgekeeper bot commented May 30, 2023

👋 Welcome back njian! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 33d9a857308eed53e06b448691910bc8aa2f8fc9 8307572: AArch64: Vector registers are clobbered by some macroassemblers May 30, 2023
@openjdk
Copy link

openjdk bot commented May 30, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 30, 2023

@nsjian This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307572: AArch64: Vector registers are clobbered by some macroassemblers

Reviewed-by: aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • f80be82: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree()
  • b6a5d20: 8269091: javax/sound/sampled/Clip/SetPositionHang.java failed with ArrayIndexOutOfBoundsException: Array index out of range: -4

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 30, 2023
@mlbridge
Copy link

mlbridge bot commented May 30, 2023

Webrevs

@nsjian
Copy link
Author

nsjian commented May 31, 2023

Got jdk17u-fix-yes.

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 31, 2023
@openjdk
Copy link

openjdk bot commented May 31, 2023

@nsjian
Your change (at version 108b326) is now ready to be sponsored by a Committer.

@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Jun 13, 2023
@nsjian
Copy link
Author

nsjian commented Jun 13, 2023

Thanks for the review! @theRealAph
My tests are clean, and I've also got jdk17u-fix-yes in JBS. Can any committer please help to sponsor this PR? Thanks!

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 13, 2023
@openjdk
Copy link

openjdk bot commented Jun 13, 2023

@nsjian
Your change (at version c9ea1ae) is now ready to be sponsored by a Committer.

@theRealAph
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 13, 2023

Going to push as commit e898048.
Since your change was applied there have been 2 commits pushed to the master branch:

  • f80be82: 8304976: Optimize DateTimeFormatterBuilder.ZoneTextPrinterParser.getTree()
  • b6a5d20: 8269091: javax/sound/sampled/Clip/SetPositionHang.java failed with ArrayIndexOutOfBoundsException: Array index out of range: -4

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 13, 2023
@openjdk openjdk bot closed this Jun 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 13, 2023
@openjdk
Copy link

openjdk bot commented Jun 13, 2023

@theRealAph @nsjian Pushed as commit e898048.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants