-
Notifications
You must be signed in to change notification settings - Fork 223
8307572: AArch64: Vector registers are clobbered by some macroassemblers #1406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Clean backport of JDK-8307572. Fixes a hidden aarch64 issue, which may cause incorrect result with several common intrinsics used.
👋 Welcome back njian! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@nsjian This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
Got jdk17u-fix-yes. /integrate |
Thanks for the review! @theRealAph /integrate |
/sponsor |
Going to push as commit e898048.
Your commit was automatically rebased without conflicts. |
@theRealAph @nsjian Pushed as commit e898048. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport of JDK-8307572 to fix a hidden aarch64 issue, which may cause incorrect result with several common intrinsics used. Test case included in the patch failed without the fix and passed with this patch. No new jtreg test failure with both release and fastdebug build.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1406/head:pull/1406
$ git checkout pull/1406
Update a local copy of the PR:
$ git checkout pull/1406
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1406/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1406
View PR using the GUI difftool:
$ git pr show -t 1406
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1406.diff
Webrev
Link to Webrev Comment