Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 5, 2023

I backport this for parity with 17.0.9-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306718: Optimize and opensource some old AWT tests (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1550/head:pull/1550
$ git checkout pull/1550

Update a local copy of the PR:
$ git checkout pull/1550
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1550/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1550

View PR using the GUI difftool:
$ git pr show -t 1550

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1550.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 5, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9beae21864d18054ca3762ec989d51ff0660db84 8306718: Optimize and opensource some old AWT tests Jul 5, 2023
@openjdk
Copy link

openjdk bot commented Jul 5, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 5, 2023
@openjdk
Copy link

openjdk bot commented Jul 5, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306718: Optimize and opensource some old AWT tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 5, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 5, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jul 10, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jul 10, 2023

Going to push as commit ed698e6.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 5fd04f9: 8285980: Several tests in compiler/c2/irTests miss @requires vm.compiler2.enabled
  • efd7f7f: 8306137: Open source several AWT ScrollPane related tests
  • 592d64b: 8310549: avoid potential leaks in KeystoreImpl.m related to JNU_CHECK_EXCEPTION early returns
  • 7a4708b: 8301700: Increase the default TLS Diffie-Hellman group size from 1024-bit to 2048-bit
  • 966fc82: 8276799: Implementation of JEP 422: Linux/RISC-V Port
  • f02d019: 8306765: Some client related jtreg problem list entries are malformed
  • c39f3c1: 8278141: LIR_OpLoadKlass::_info shadows the field of the same name from LIR_Op
  • a34d90b: 8277860: PPC: Remove duplicate info != NULL check
  • d7a59f3: 8277417: C1 LIR instruction for load-klass
  • c2e274e: 8304725: AsyncGetCallTrace can cause SIGBUS on M1
  • ... and 9 more: https://git.openjdk.org/jdk17u-dev/compare/e8e87c47d8f1d35b83e8bae867a7426866108731...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 10, 2023
@openjdk openjdk bot closed this Jul 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 10, 2023
@openjdk
Copy link

openjdk bot commented Jul 10, 2023

@GoeLin Pushed as commit ed698e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant