Skip to content

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Aug 22, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8276651: java/lang/ProcessHandle tests fail with "RuntimeException: Input/output error" in java.lang.ProcessHandleImpl$Info.info0 (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1685/head:pull/1685
$ git checkout pull/1685

Update a local copy of the PR:
$ git checkout pull/1685
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1685/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1685

View PR using the GUI difftool:
$ git pr show -t 1685

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1685.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d24b7b7026cf85f1aecf44f60819762872cfd5c1 8276651: java/lang/ProcessHandle tests fail with "RuntimeException: Input/output error" in java.lang.ProcessHandleImpl$Info.info0 Aug 22, 2023
@openjdk
Copy link

openjdk bot commented Aug 22, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 22, 2023
@openjdk
Copy link

openjdk bot commented Aug 22, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276651: java/lang/ProcessHandle tests fail with "RuntimeException: Input/output error" in java.lang.ProcessHandleImpl$Info.info0

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 22, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 22, 2023

Webrevs

@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 25, 2023

Going to push as commit 1421540.
Since your change was applied there have been 8 commits pushed to the master branch:

  • d9985d0: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev
  • e84d9dd: 8313701: GHA: RISC-V should use the official repository for bootstrap
  • e070c31: 8283724: Incorrect description for jtreg-failure-handler option
  • 40add10: 8299827: Add resolved IP address in connection exception for sockets
  • e830464: 8314552: Fix javadoc tests to work with jtreg 7
  • 49ffbcf: 8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails
  • d35a896: 8293851: hs_err should print more stack in hex dump
  • 3f8e995: 8314658: [17u] GHA: Sync up debian-version for cross-builds

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 25, 2023
@openjdk openjdk bot closed this Aug 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 25, 2023
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@MBaesken Pushed as commit 1421540.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant