Skip to content

8176567: nsk/jdi/ReferenceType/instances/instances002: TestFailure: Unexpected size of referenceType.instances(nsk.share.jdi.TestInterfaceImplementer1): 11, expected: 10 #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 23, 2023

I backport this for parity with 17.0.10-oracle.

A trivial resolve, probably clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8176567 needs maintainer approval

Issue

  • JDK-8176567: nsk/jdi/ReferenceType/instances/instances002: TestFailure: Unexpected size of referenceType.instances(nsk.share.jdi.TestInterfaceImplementer1): 11, expected: 10 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1901/head:pull/1901
$ git checkout pull/1901

Update a local copy of the PR:
$ git checkout pull/1901
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1901/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1901

View PR using the GUI difftool:
$ git pr show -t 1901

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1901.diff

Webrev

Link to Webrev Comment

@GoeLin GoeLin force-pushed the goetz_backport_8176567 branch from bbb986f to ad91db4 Compare October 23, 2023 14:05
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6b833db3f9cace8fbb09bb803ba31208e37a4622 8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases? Oct 23, 2023
@openjdk
Copy link

openjdk bot commented Oct 23, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Oct 23, 2023
@openjdk
Copy link

openjdk bot commented Oct 23, 2023

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 23, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 23, 2023

Webrevs

@GoeLin GoeLin changed the title 8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases? Backport 46fd683820bb7149c0605a0ba03f59e76de69c16 Oct 24, 2023
@openjdk openjdk bot changed the title Backport 46fd683820bb7149c0605a0ba03f59e76de69c16 8176567: nsk/jdi/ReferenceType/instances/instances002: TestFailure: Unexpected size of referenceType.instances(nsk.share.jdi.TestInterfaceImplementer1): 11, expected: 10 Oct 24, 2023
@openjdk
Copy link

openjdk bot commented Oct 24, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the clean label Oct 24, 2023
@openjdk
Copy link

openjdk bot commented Oct 24, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Oct 24, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8176567: nsk/jdi/ReferenceType/instances/instances002: TestFailure: Unexpected size of referenceType.instances(nsk.share.jdi.TestInterfaceImplementer1): 11, expected: 10

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 73c3316: 8268916: Tests for AffirmTrust roots
  • f1ce4ef: 8317967: Enhance test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java to handle default cases
  • 6414676: 8291154: Create a non static nested class without enclosing class throws VerifyError
  • 10b7536: 8275333: Print count in "Too many recored phases?" assert

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 24, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Oct 25, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 25, 2023

Going to push as commit 748ccc5.
Since your change was applied there have been 6 commits pushed to the master branch:

  • ffb4ef2: 8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases?
  • 9a1f8cb: 8311511: Improve description of NativeLibrary JFR event
  • 73c3316: 8268916: Tests for AffirmTrust roots
  • f1ce4ef: 8317967: Enhance test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java to handle default cases
  • 6414676: 8291154: Create a non static nested class without enclosing class throws VerifyError
  • 10b7536: 8275333: Print count in "Too many recored phases?" assert

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 25, 2023
@openjdk openjdk bot closed this Oct 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 25, 2023
@openjdk
Copy link

openjdk bot commented Oct 25, 2023

@GoeLin Pushed as commit 748ccc5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8176567 branch October 25, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant