Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320712: Rewrite BadFactoryTest in pure Java #2267

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 4, 2024

I backport this for parity with 17.0.12-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320712 needs maintainer approval

Issue

  • JDK-8320712: Rewrite BadFactoryTest in pure Java (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2267/head:pull/2267
$ git checkout pull/2267

Update a local copy of the PR:
$ git checkout pull/2267
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2267/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2267

View PR using the GUI difftool:
$ git pr show -t 2267

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2267.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 66971600f7ba796ff5bb9714591c3faa0bb2249d 8320712: Rewrite BadFactoryTest in pure Java Mar 4, 2024
@openjdk
Copy link

openjdk bot commented Mar 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 4, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 4, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 4, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Mar 6, 2024

GHA issue: Risc-V build failure, unrelated.

@openjdk openjdk bot added the approval label Mar 6, 2024
@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320712: Rewrite BadFactoryTest in pure Java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • fa8a159: 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel
  • 3c05a02: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop
  • f423686: 8325972: Add -x to bash for building with LOG=debug
  • 385731f: 8320303: Allow PassFailJFrame to accept single window creator
  • 30ead33: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053
  • 5421bb6: 8278893: Parallel: Remove GCWorkerDelayMillis
  • dbf4a99: 8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range
  • 47ec134: Merge
  • f45e587: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  • 72881de: 8305900: Use loopback IP addresses in security policy files of httpclient tests
  • ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/bfe8974e532952bfd255d85d9afe7043b8a09a55...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 7, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Mar 7, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 7, 2024

Going to push as commit 08f1b35.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 6e73b11: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27
  • 48327c3: 8309763: Move tests in test/jdk/sun/misc/URLClassPath directory to test/jdk/jdk/internal/loader
  • fa8a159: 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel
  • 3c05a02: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop
  • f423686: 8325972: Add -x to bash for building with LOG=debug
  • 385731f: 8320303: Allow PassFailJFrame to accept single window creator
  • 30ead33: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053
  • 5421bb6: 8278893: Parallel: Remove GCWorkerDelayMillis
  • dbf4a99: 8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range
  • 47ec134: Merge
  • ... and 4 more: https://git.openjdk.org/jdk17u-dev/compare/bfe8974e532952bfd255d85d9afe7043b8a09a55...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 7, 2024
@openjdk openjdk bot closed this Mar 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 7, 2024
@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@GoeLin Pushed as commit 08f1b35.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant