Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 7, 2024

I backport this for parity with 17.0.14-oracle

Resolved import, probably clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8330278 needs maintainer approval

Issue

  • JDK-8330278: Have SSLSocketTemplate.doClientSide use loopback address (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3036/head:pull/3036
$ git checkout pull/3036

Update a local copy of the PR:
$ git checkout pull/3036
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3036/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3036

View PR using the GUI difftool:
$ git pr show -t 3036

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3036.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 7, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330278: Have SSLSocketTemplate.doClientSide use loopback address

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • d2b244d: 8340387: Update OS detection code to recognize Windows Server 2025
  • 0d7b272: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files
  • 93b2aa4: 8343687: [17u] TestAntiDependencyForPinnedLoads requires UTF-8
  • 5819d91: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option
  • b0c75b4: 8341235: Improve default instruction frame title in PassFailJFrame
  • eb46442: 8340799: Add border inside instruction frame in PassFailJFrame
  • d1be3c9: 8340812: LambdaForm customization via MethodHandle::updateForm is not thread safe
  • 6c7f622: 8337851: Some tests have name which confuse jtreg
  • 24769df: 8338751: ConfigureNotify behavior has changed in KWin 6.2
  • 18ea311: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/a7fc50c8e482c7b2a25fd8ee9e6b4bea01e6eb82...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 0eff492e4107abc5624f0c3445877bf38629a980 8330278: Have SSLSocketTemplate.doClientSide use loopback address Nov 7, 2024
@openjdk
Copy link

openjdk bot commented Nov 7, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Nov 7, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 7, 2024

Webrevs

@GoeLin GoeLin force-pushed the goetz_backport_8330278 branch from 9a6cfe9 to 30c3660 Compare November 8, 2024 08:00
@openjdk
Copy link

openjdk bot commented Nov 8, 2024

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the clean Identical backport; no merge resolution required label Nov 8, 2024
@openjdk
Copy link

openjdk bot commented Nov 8, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 8, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Nov 11, 2024

GHA failure: infra issue, unrelated.

@GoeLin
Copy link
Member Author

GoeLin commented Nov 11, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Nov 11, 2024

Going to push as commit f448955.
Since your change was applied there have been 14 commits pushed to the master branch:

  • c41236b: 8240343: JDI stopListening/stoplis001 "FAILED: listening is successfully stopped without starting listening"
  • f8a119b: 8327924: Simplify TrayIconScalingTest.java
  • 915cc66: 8325038: runtime/cds/appcds/ProhibitedPackage.java can fail with UseLargePages
  • d2b244d: 8340387: Update OS detection code to recognize Windows Server 2025
  • 0d7b272: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files
  • 93b2aa4: 8343687: [17u] TestAntiDependencyForPinnedLoads requires UTF-8
  • 5819d91: 8342681: TestLoadBypassesNullCheck.java fails improperly specified VM option
  • b0c75b4: 8341235: Improve default instruction frame title in PassFailJFrame
  • eb46442: 8340799: Add border inside instruction frame in PassFailJFrame
  • d1be3c9: 8340812: LambdaForm customization via MethodHandle::updateForm is not thread safe
  • ... and 4 more: https://git.openjdk.org/jdk17u-dev/compare/a7fc50c8e482c7b2a25fd8ee9e6b4bea01e6eb82...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 11, 2024
@openjdk openjdk bot closed this Nov 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 11, 2024
@openjdk
Copy link

openjdk bot commented Nov 11, 2024

@GoeLin Pushed as commit f448955.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8330278 branch November 11, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant