8304163: Move jdk.internal.module.ModuleInfoWriter to the test library

[GoeLin]

I had to resolve three files and adapt the tests to compile (see extra commit)

test/hotspot/jtreg/serviceability/dcmd/framework/VMVersionTest.java
Resolved test instructions as later change was already backported.

test/jdk/java/lang/module/ModuleDescriptorTest.java
Several resolves. Some previous changes that can not be backported.

test/lib/jdk/test/lib/util/ModuleInfoWriter.java
Resolved

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8304163 needs maintainer approval

Issue

• JDK-8304163: Move jdk.internal.module.ModuleInfoWriter to the test library (Enhancement - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3917/head:pull/3917
$ git checkout pull/3917

Update a local copy of the PR:
$ git checkout pull/3917
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3917/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3917

View PR using the GUI difftool:
$ git pr show -t 3917

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3917.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304163: Move jdk.internal.module.ModuleInfoWriter to the test library

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• 58ac267: 8353950: Clipboard interaction on Windows is unstable
• 16996c0: 8353309: Open source several Swing text tests
• 269a925: 8354495: Open source several AWT DataTransfer tests
• ... and 25 more: https://git.openjdk.org/jdk17u-dev/compare/50441c9473e7957caa14de666bec62e1c2446e38...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (5e01b1dc)
• 00: Full (6bf081a6)

[GoeLin]

GHA failure: Annotations test needs adption.
linux-x64,
macos-aarch64
macos-x64
windows-x64

Update: passes now.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

Thanks for the review!

[GoeLin]

/integrate

[openjdk]

Going to push as commit 6cc8472.
Since your change was applied there have been 29 commits pushed to the master branch:

• 9f3c646: 8285915: failure_handler: gather the contents of /etc/hosts file
• 58ac267: 8353950: Clipboard interaction on Windows is unstable
• 16996c0: 8353309: Open source several Swing text tests
• ... and 26 more: https://git.openjdk.org/jdk17u-dev/compare/50441c9473e7957caa14de666bec62e1c2446e38...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 6cc8472.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.