-
Notifications
You must be signed in to change notification settings - Fork 232
8372439: [17u] build-test-lib is broken #4195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s that only exist in JDK21+
|
👋 Welcome back mmm-choi! A progress list of the required criteria for merging this PR into |
|
@mmm-choi This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
|
|
/approval Fixes |
|
@mmm-choi usage: |
|
/approval request Fixes make build-test-lib due to slightly incorrect backport. |
|
/integrate |
|
/sponsor |
|
Going to push as commit 5831f3b. |
make build-test-libis broken.#3917 was not tested with
make build-test-lib, and introduced a bug#1801 added incorrect
--add-exportsand was tested by themake build-test-lib, but it did not have the patch above.classfiledoes not exist in JDK17, see openjdk/jdk#10982Ran
make build-test-liblocally, all builds pass.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4195/head:pull/4195$ git checkout pull/4195Update a local copy of the PR:
$ git checkout pull/4195$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4195/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4195View PR using the GUI difftool:
$ git pr show -t 4195Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4195.diff
Using Webrev
Link to Webrev Comment