Skip to content

Conversation

@mmm-choi
Copy link
Contributor

@mmm-choi mmm-choi commented Nov 24, 2025

make build-test-lib is broken.

#3917 was not tested with make build-test-lib, and introduced a bug
#1801 added incorrect --add-exports and was tested by the make build-test-lib, but it did not have the patch above.

classfile does not exist in JDK17, see openjdk/jdk#10982

Ran make build-test-lib locally, all builds pass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8372439 needs maintainer approval

Issue

  • JDK-8372439: [17u] build-test-lib is broken (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4195/head:pull/4195
$ git checkout pull/4195

Update a local copy of the PR:
$ git checkout pull/4195
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4195/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4195

View PR using the GUI difftool:
$ git pr show -t 4195

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4195.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2025

👋 Welcome back mmm-choi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 24, 2025

@mmm-choi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372439: [17u] build-test-lib is broken

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 24, 2025
@mmm-choi mmm-choi changed the title 8372439: build-test-lib is broken 8372439: [17u] build-test-lib is broken Nov 24, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 24, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 24, 2025

⚠️ @mmm-choi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@mmm-choi
Copy link
Contributor Author

/approval Fixes make build-test-lib due to slightly incorrect backport.

@openjdk
Copy link

openjdk bot commented Nov 24, 2025

@mmm-choi usage: /approval [<id>] (request|cancel) [<text>]

@mmm-choi
Copy link
Contributor Author

/approval request Fixes make build-test-lib due to slightly incorrect backport.

@openjdk
Copy link

openjdk bot commented Nov 24, 2025

@mmm-choi
8372439: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 24, 2025
@mmm-choi
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 26, 2025
@openjdk
Copy link

openjdk bot commented Nov 26, 2025

@mmm-choi
Your change (at version 0158a7d) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 26, 2025

Going to push as commit 5831f3b.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 26, 2025
@openjdk openjdk bot closed this Nov 26, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 26, 2025
@openjdk
Copy link

openjdk bot commented Nov 26, 2025

@shipilev @mmm-choi Pushed as commit 5831f3b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mmm-choi mmm-choi deleted the JDK-8372439 branch November 26, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants