8364263: HttpClient: Improve encapsulation of ProxyServer

[GoeLin]

I backport this for parity with 17.0.18-oracle.

Clean backport, but needed to remove platform thread coding.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8364263 needs maintainer approval

Issue

• JDK-8364263: HttpClient: Improve encapsulation of ProxyServer (Enhancement - P4 - Approved)

Reviewers

• Ralf Schmelter (@schmelter-sap - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4111/head:pull/4111
$ git checkout pull/4111

Update a local copy of the PR:
$ git checkout pull/4111
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4111/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4111

View PR using the GUI difftool:
$ git pr show -t 4111

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4111.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364263: HttpClient: Improve encapsulation of ProxyServer

Reviewed-by: rschmelter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 9e1a6be: 8367348: Enhance PassFailJFrame to support links in HTML
• f278bdc: 7191877: TEST_BUG: java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak.java failing intermittently
• e15abf3: 8324065: Daylight saving information for Africa/Casablanca are incorrect
• ... and 6 more: https://git.openjdk.org/jdk17u-dev/compare/f4c80e318a4a72f5308310d352e5504414716fa4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (2b23bdef)

[GoeLin]

GHA failure: test java/lang/ProcessBuilder/Basic#id0 failed. Unrelated.

[schmelter-sap]

Looks good.

[GoeLin]

GHA failure: java/lang/ProcessBuilder/Basic#id0 failed. Unrelated.
Might be fixed by #4097

[GoeLin]

/integrate

[openjdk]

@GoeLin This pull request has not yet been marked as ready for integration.

[schmelter-sap]

Forgot to approve.

[GoeLin]

Thanks :)

[GoeLin]

/integrate

[openjdk]

Going to push as commit 63406ab.
Since your change was applied there have been 9 commits pushed to the master branch:

• 9e1a6be: 8367348: Enhance PassFailJFrame to support links in HTML
• f278bdc: 7191877: TEST_BUG: java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak.java failing intermittently
• e15abf3: 8324065: Daylight saving information for Africa/Casablanca are incorrect
• ... and 6 more: https://git.openjdk.org/jdk17u-dev/compare/f4c80e318a4a72f5308310d352e5504414716fa4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 63406ab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.