Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 23, 2025

I backport this for parity with 17.0.18-oracle.

Omitted change to ProblemList as test is not listed.

Resolved @bug list.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8368192 needs maintainer approval

Issue

  • JDK-8368192: Test java/lang/ProcessBuilder/Basic.java#id0 fails with Exception: Stack trace (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4097/head:pull/4097
$ git checkout pull/4097

Update a local copy of the PR:
$ git checkout pull/4097
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4097/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4097

View PR using the GUI difftool:
$ git pr show -t 4097

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4097.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 23, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368192: Test java/lang/ProcessBuilder/Basic.java#id0 fails with Exception: Stack trace

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport 218e82c875237f82a649a214c72d925a5ebf188c 8368192: Test java/lang/ProcessBuilder/Basic.java#id0 fails with Exception: Stack trace Oct 23, 2025
@openjdk
Copy link

openjdk bot commented Oct 23, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 23, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 23, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 27, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@GoeLin
Copy link
Member Author

GoeLin commented Oct 27, 2025

Hi @phohensee
thanks for the reviews!

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 27, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Oct 28, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

Going to push as commit 2b5b97b.
Since your change was applied there have been 24 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 28, 2025
@openjdk openjdk bot closed this Oct 28, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@GoeLin Pushed as commit 2b5b97b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8368192 branch October 28, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants