-
Notifications
You must be signed in to change notification settings - Fork 232
8294591: Fix cast-function-type warning in TemplateTable #4127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
48c7cdc to
e35becd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backport looks fine.
|
|
|
/approval request Backporting this to unblock MacOS compiler update. The patch does not apply cleanly because JDK-8294314 is not in 17u; this is trivially resolved. The patch has no bug-tail after more than 3 years in mainline, and it passes all tests. |
Need this to unblock MacOS compiler update in GHA.
Partially backports original openjdk/jdk@fc61658. There is a conflict, because the original JDK-8294314 that added more verbose build warnings is not in 17u-dev yet. If we backport that one later, we can remove the warning blocks related to these files.
Additional testing:
allallProgress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4127/head:pull/4127$ git checkout pull/4127Update a local copy of the PR:
$ git checkout pull/4127$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4127/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4127View PR using the GUI difftool:
$ git pr show -t 4127Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4127.diff
Using Webrev
Link to Webrev Comment