Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Oct 28, 2025

Need this to unblock MacOS compiler update in GHA.

Partially backports original openjdk/jdk@fc61658. There is a conflict, because the original JDK-8294314 that added more verbose build warnings is not in 17u-dev yet. If we backport that one later, we can remove the warning blocks related to these files.

Additional testing:

  • Linux AArch64 server fastdebug, all
  • Linux x86_64 server fastdebug, all

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8294591 needs maintainer approval

Issue

  • JDK-8294591: Fix cast-function-type warning in TemplateTable (Enhancement - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4127/head:pull/4127
$ git checkout pull/4127

Update a local copy of the PR:
$ git checkout pull/4127
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4127/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4127

View PR using the GUI difftool:
$ git pr show -t 4127

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4127.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport fc616588c1bf731150a9d9b80033bb589bcb231f 8294591: Fix cast-function-type warning in TemplateTable Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Oct 28, 2025
@shipilev shipilev force-pushed the JDK-8294591-macos-templatetable branch from 48c7cdc to e35becd Compare October 29, 2025 16:14
@shipilev shipilev marked this pull request as ready for review October 29, 2025 16:25
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 29, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 29, 2025

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks fine.

@openjdk
Copy link

openjdk bot commented Oct 30, 2025

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@shipilev
Copy link
Member Author

/approval request Backporting this to unblock MacOS compiler update. The patch does not apply cleanly because JDK-8294314 is not in 17u; this is trivially resolved. The patch has no bug-tail after more than 3 years in mainline, and it passes all tests.

@openjdk
Copy link

openjdk bot commented Oct 30, 2025

@shipilev
8294591: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants