Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 9, 2022

I backport this for parity with 17.0.5-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8178969: [TESTBUG] Wrong reporting of gc/g1/humongousObjects/TestHeapCounters test.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/452/head:pull/452
$ git checkout pull/452

Update a local copy of the PR:
$ git checkout pull/452
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/452/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 452

View PR using the GUI difftool:
$ git pr show -t 452

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/452.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4f2e4c7c249812c16ef04058124892475e1043ed 8178969: [TESTBUG] Wrong reporting of gc/g1/humongousObjects/TestHeapCounters test. Jun 9, 2022
@openjdk
Copy link

openjdk bot commented Jun 9, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 9, 2022
@openjdk
Copy link

openjdk bot commented Jun 9, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8178969: [TESTBUG] Wrong reporting of gc/g1/humongousObjects/TestHeapCounters test.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 9, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 9, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jun 13, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 13, 2022

Going to push as commit 292d90d.
Since your change was applied there have been 7 commits pushed to the master branch:

  • a081e4a: 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int)
  • aa3d2f7: 8172065: javax/swing/JTree/4908142/bug4908142.java The selected index should be "aad"
  • 66cdd6e: 8284694: Avoid evaluating SSLAlgorithmConstraints twice
  • 92d617f: 8159694: HiDPI, Unity, java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java
  • 667582d: 8285820: C2: LCM prioritizes locally dependent CreateEx nodes over projections after 8270090
  • 2da3752: 8270090: C2: LCM may prioritize CheckCastPP nodes over projections
  • 7023eef: 8287741: Fix of JDK-8287107 (unused cgv1 freezer controller) was incomplete

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 13, 2022
@openjdk openjdk bot closed this Jun 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 13, 2022
@openjdk
Copy link

openjdk bot commented Jun 13, 2022

@GoeLin Pushed as commit 292d90d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant