Skip to content

Conversation

@benty-amzn
Copy link

@benty-amzn benty-amzn commented Nov 22, 2022

Backporting to 17 for improved performance.
Backport is clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297211: Expensive fillInStackTrace operation in HttpURLConnection.getOutputStream0 when no content-length in response

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/918/head:pull/918
$ git checkout pull/918

Update a local copy of the PR:
$ git checkout pull/918
$ git pull https://git.openjdk.org/jdk17u-dev pull/918/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 918

View PR using the GUI difftool:
$ git pr show -t 918

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/918.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2022

👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 392ac7055d4697c56fa85ac5572f5bc4dc431f1d 8297211: Expensive fillInStackTrace operation in HttpURLConnection.getOutputStream0 when no content-length in response Nov 22, 2022
@openjdk
Copy link

openjdk bot commented Nov 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 22, 2022
@openjdk
Copy link

openjdk bot commented Nov 22, 2022

@benty-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297211: Expensive fillInStackTrace operation in HttpURLConnection.getOutputStream0 when no content-length in response

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 26b03b5: 8297259: Bump update version for OpenJDK: jdk-17.0.7

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 22, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2022

Webrevs

@RealCLanger
Copy link
Contributor

@benty-amzn, could you please enable GHA testing?

@benty-amzn
Copy link
Author

GHA tests are now enabled and passing

@phohensee
Copy link
Member

Testing? Please enable pre-submit testing on your repo.

@benty-amzn
Copy link
Author

Rebased on current master to try to get tests to run - they are enabled but didn't run for some reason

@benty-amzn
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 7, 2022
@openjdk
Copy link

openjdk bot commented Dec 7, 2022

@benty-amzn
Your change (at version efe5dae) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 7, 2022

Going to push as commit a2fb9ae.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 26b03b5: 8297259: Bump update version for OpenJDK: jdk-17.0.7

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 7, 2022
@openjdk openjdk bot closed this Dec 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 7, 2022
@openjdk
Copy link

openjdk bot commented Dec 7, 2022

@phohensee @benty-amzn Pushed as commit a2fb9ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants