-
Notifications
You must be signed in to change notification settings - Fork 61
8310259: Pin msys2/setup-msys2 github action to a specific commit #31
Conversation
👋 Welcome back jpai! A progress list of the required criteria for merging this PR into |
Could you then please also add the issue JDK-8309934 to this PR? |
/issue add JDK-8309934 |
@RealCLanger Only the author (@jaikiran) is allowed to issue the |
/issue add JDK-8309934 |
@jaikiran |
This backport pull request has now been updated with issue from the original commit. |
@jaikiran This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thank you Christian and Christoph for the reviews. |
/integrate |
Going to push as commit 08965e6.
Your commit was automatically rebased without conflicts. |
Can I please get a review of this change which backports the fixes for https://bugs.openjdk.org/browse/JDK-8310259?
This wasn't a clean backport because this also brings in https://bugs.openjdk.org/browse/JDK-8309934 which in theory isn't a must-have change, but I think it's good to have these changes match with what's in mainline.
With this commit in this PR, the windows github actions jobs that are failing in this jdk21 repo, should now continue to pass.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/31/head:pull/31
$ git checkout pull/31
Update a local copy of the PR:
$ git checkout pull/31
$ git pull https://git.openjdk.org/jdk21.git pull/31/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31
View PR using the GUI difftool:
$ git pr show -t 31
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/31.diff
Webrev
Link to Webrev Comment