Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
/ jdk21 Public archive

8310259: Pin msys2/setup-msys2 github action to a specific commit #31

Closed
wants to merge 1 commit into from

Conversation

jaikiran
Copy link
Member

@jaikiran jaikiran commented Jun 19, 2023

Can I please get a review of this change which backports the fixes for https://bugs.openjdk.org/browse/JDK-8310259?

This wasn't a clean backport because this also brings in https://bugs.openjdk.org/browse/JDK-8309934 which in theory isn't a must-have change, but I think it's good to have these changes match with what's in mainline.

With this commit in this PR, the windows github actions jobs that are failing in this jdk21 repo, should now continue to pass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8310259: Pin msys2/setup-msys2 github action to a specific commit (Task - P4)
  • JDK-8309934: Update GitHub Actions to use JDK 17 for building jtreg (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21.git pull/31/head:pull/31
$ git checkout pull/31

Update a local copy of the PR:
$ git checkout pull/31
$ git pull https://git.openjdk.org/jdk21.git pull/31/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31

View PR using the GUI difftool:
$ git pr show -t 31

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21/pull/31.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 19, 2023

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 19, 2023
@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@jaikiran The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Jun 19, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 19, 2023

Webrevs

@RealCLanger
Copy link
Contributor

Could you then please also add the issue JDK-8309934 to this PR?

@RealCLanger
Copy link
Contributor

/issue add JDK-8309934

@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@RealCLanger Only the author (@jaikiran) is allowed to issue the /issue command.

@jaikiran
Copy link
Member Author

/issue add JDK-8309934

@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@jaikiran
Adding additional issue to issue list: 8309934: Update GitHub Actions to use JDK 17 for building jtreg.

@jaikiran jaikiran changed the title 8310306: Pin msys2/setup-msys2 github action to a specific commit Backport 959a61fdd483c9523764b9ba0972f59ca06db0ee Jun 19, 2023
@openjdk openjdk bot changed the title Backport 959a61fdd483c9523764b9ba0972f59ca06db0ee 8310259: Pin msys2/setup-msys2 github action to a specific commit Jun 19, 2023
@openjdk
Copy link

openjdk bot commented Jun 19, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jun 19, 2023
@openjdk
Copy link

openjdk bot commented Jun 19, 2023

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310259: Pin msys2/setup-msys2 github action to a specific commit
8309934: Update GitHub Actions to use JDK 17 for building jtreg

Reviewed-by: cstein, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 36e3fe9: 8309928: JFR: View issues
  • 4d81b89: 8309960: ParallelGC young collections very slow in DelayInducer

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 19, 2023
@jaikiran
Copy link
Member Author

Thank you Christian and Christoph for the reviews.

@jaikiran
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 20, 2023

Going to push as commit 08965e6.
Since your change was applied there have been 4 commits pushed to the master branch:

  • e0d3706: 8304835: jdk/jfr/event/oldobject/TestArrayInformation.java fails with "Could not find event with class ... as (leak) object"
  • 14c5091: 8310015: ZGC: Unbounded asynchronous unmapping can lead to running out of address space
  • 36e3fe9: 8309928: JFR: View issues
  • 4d81b89: 8309960: ParallelGC young collections very slow in DelayInducer

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 20, 2023
@openjdk openjdk bot closed this Jun 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 20, 2023
@openjdk
Copy link

openjdk bot commented Jun 20, 2023

@jaikiran Pushed as commit 08965e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jaikiran jaikiran deleted the 8310306 branch June 20, 2023 01:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants