8333456: CompactNumberFormat integer parsing fails when string has no suffix

[rm-gh-8]

Backporting JDK-8333456: CompactNumberFormat integer parsing fails when string has no suffix. Adds logic to check to make sure position does not exceed the string length before deciding to check for a decimal symbol.

Ran GHA Sanity Checks (passed) and related test (passed).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8333456 needs maintainer approval

Issue

• JDK-8333456: CompactNumberFormat integer parsing fails when string has no suffix (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2468/head:pull/2468
$ git checkout pull/2468

Update a local copy of the PR:
$ git checkout pull/2468
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2468/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2468

View PR using the GUI difftool:
$ git pr show -t 2468

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2468.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (354993ce)
• 01: Full - Incremental (0c2007ca)
• 00: Full (5a316af9)

[rm-gh-8]

/approval request for backport of JDK-8333456: CompactNumberFormat integer parsing fails when string has no suffix.

Ran the updated and related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

(All Passed) - make test TEST=test/jdk/java/text/Format

Results are attached.
linux-aarch64-specific-test.log
linux-x64-specific-test.log
macos-aarch64-specific-test.log
windows-x64-specific-test.log

[openjdk]

@rm-gh-8
8333456: The approval request has been created successfully.

[phohensee]

LenientParseTest.java was brought in as part of JDK-8327640, which was a large patch and required a CSR, thus including it in this PR is unlikely to be approved by the maintainers. I would drop this PR.

If you do want to get this fix done, I'd file a new JBS issue against 21u and write a new test for just this fix.

[rm-gh-8]

LenientParseTest.java was brought in as part of JDK-8327640, which was a large patch and required a CSR, thus including it in this PR is unlikely to be approved by the maintainers. I would drop this PR.

If you do want to get this fix done, I'd file a new JBS issue against 21u and write a new test for just this fix.

Removed LenientParseTest.java and created Bug8333456.java to contain the specific test.

Ran the test:

(Passed) make test TEST=test/jdk/java/text/Format/NumberFormat/Bug8333456.java

Result attached.
macos-aarch64-specific-test.log

[GoeLin]

Hi @rm-gh-8
please only request approval if the change is reviewed.
Removing the label in the meantime.