Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

8322321: Add man page doc for -XX:+VerifySharedSpaces #24

Conversation

iklam
Copy link
Member

@iklam iklam commented Dec 20, 2023

Clean backport.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322321: Add man page doc for -XX:+VerifySharedSpaces (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk22.git pull/24/head:pull/24
$ git checkout pull/24

Update a local copy of the PR:
$ git checkout pull/24
$ git pull https://git.openjdk.org/jdk22.git pull/24/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24

View PR using the GUI difftool:
$ git pr show -t 24

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk22/pull/24.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2023

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f7dc257a206d3104d6d24c2079ef1fe349368c49 8322321: Add man page doc for -XX:+VerifySharedSpaces Dec 20, 2023
@openjdk
Copy link

openjdk bot commented Dec 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 20, 2023
@openjdk
Copy link

openjdk bot commented Dec 20, 2023

@iklam To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@iklam
Copy link
Member Author

iklam commented Dec 20, 2023

/label hotspot

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Dec 20, 2023
@openjdk
Copy link

openjdk bot commented Dec 20, 2023

@iklam
The hotspot label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 20, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 21, 2023

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322321: Add man page doc for -XX:+VerifySharedSpaces

Reviewed-by: ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 21, 2023
@iklam
Copy link
Member Author

iklam commented Dec 21, 2023

Thanks @calvinccheung
/integrate

@openjdk
Copy link

openjdk bot commented Dec 21, 2023

Going to push as commit ea6d79f.
Since your change was applied there have been 2 commits pushed to the master branch:

  • c249229: 8322154: RISC-V: JDK-8315743 missed change in MacroAssembler::load_reserved
  • fb3cc98: 8321565: [REDO] Heap dump does not contain virtual Thread stack references

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 21, 2023
@openjdk openjdk bot closed this Dec 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 21, 2023
@openjdk
Copy link

openjdk bot commented Dec 21, 2023

@iklam Pushed as commit ea6d79f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
2 participants