Skip to content

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Dec 1, 2025

Hi all,

This pull request contains a backport of commit 0c6d1b9c from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 28 Nov 2025 and was reviewed by Tejesh R, Jayathirth D V and Alexander Zvegintsev.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8371759 needs maintainer approval

Issue

  • JDK-8371759: Add missing @Override annotations in com.sun.imageio package (Bug - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/39/head:pull/39
$ git checkout pull/39

Update a local copy of the PR:
$ git checkout pull/39
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/39/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 39

View PR using the GUI difftool:
$ git pr show -t 39

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/39.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 1, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 1, 2025

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371759: Add missing @Override annotations in com.sun.imageio package

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • f7eec4f: 8362284: RISC-V: cleanup NativeMovRegMem
  • 6e169f6: 8366747: RISC-V: Improve VerifyMethodHandles for method handle linkers

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 0c6d1b9c8bfd7f4e39a6621c7a8f7bdcd044a05f 8371759: Add missing @Override annotations in com.sun.imageio package Dec 1, 2025
@openjdk
Copy link

openjdk bot commented Dec 1, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 1, 2025
@mrserb mrserb marked this pull request as ready for review December 2, 2025 04:46
@mrserb
Copy link
Member Author

mrserb commented Dec 2, 2025

/approval request
Clean backport. Only source annotations are added; there are no behavioral changes. The patch touches many files, and I would like to backport it to the latest LTS to keep future backports cleaner.

@openjdk
Copy link

openjdk bot commented Dec 2, 2025

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 2, 2025
@openjdk
Copy link

openjdk bot commented Dec 2, 2025

@mrserb
8371759: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Dec 2, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 2, 2025

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Dec 2, 2025

Hi @mrserb
you have failing GHA tests.

@mrserb
Copy link
Member Author

mrserb commented Dec 2, 2025

Hi @mrserb you have failing GHA tests.

That is the intermittent test issues, similar failures here: #36

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Dec 3, 2025
@mrserb
Copy link
Member Author

mrserb commented Dec 3, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Dec 3, 2025

Going to push as commit 25e491b.
Since your change was applied there have been 28 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 3, 2025
@openjdk openjdk bot closed this Dec 3, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 3, 2025
@openjdk
Copy link

openjdk bot commented Dec 3, 2025

@mrserb Pushed as commit 25e491b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants