Skip to content

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Dec 1, 2025

Backporting JDK-8341778: Some javac tests ignore the result of JavacTask::call.

Multiple tests ignore the Boolean return value from JavacTask.call(), causing silent failures where tests appear to pass despite actual compilation errors. This fix adds result validation to all affected test cases.. Ran GHA Sanity Checks (passed), jtreg tier1 tests (passed) and related tests (passed) on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

(Passed) - make test-tier1
(Passed) - make test TEST=test/jdk/java/beans
(Passed) - make test TEST=test/hotspot/jtreg/vmTestbase/gc/g1/unloading

Results are attached.

linux-aarch64-jtreg-tier1.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log
linux-x64-jtreg-tier1.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
macos-aarch64-jtreg-tier1.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
windows-x64-jtreg-tier1.log
windows-x64-specific-test.log
windows-x64-specific-2-test.log


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8341778 needs maintainer approval

Issue

  • JDK-8341778: Some javac tests ignore the result of JavacTask::call (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/40/head:pull/40
$ git checkout pull/40

Update a local copy of the PR:
$ git checkout pull/40
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/40/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 40

View PR using the GUI difftool:
$ git pr show -t 40

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/40.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 1, 2025

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 8adb052b46f90e8a0605cfc5ddc667acb7c61952 8341778: Some javac tests ignore the result of JavacTask::call Dec 1, 2025
@openjdk
Copy link

openjdk bot commented Dec 1, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 1, 2025
@rm-gh-8 rm-gh-8 marked this pull request as ready for review December 2, 2025 17:16
@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Dec 2, 2025

/approval request for backport of JDK-8341778: Some javac tests ignore the result of JavacTask::call.

The commit improves existing tests by preventing silent errors propagated in tests that use "JavacTask.call()". It doesn't introduce behavioral changes.

@openjdk
Copy link

openjdk bot commented Dec 2, 2025

@rm-gh-8
8341778: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received rfr Pull request is ready for review labels Dec 2, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 2, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant