8341778: Some javac tests ignore the result of JavacTask::call #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting JDK-8341778: Some javac tests ignore the result of JavacTask::call.
Multiple tests ignore the Boolean return value from JavacTask.call(), causing silent failures where tests appear to pass despite actual compilation errors. This fix adds result validation to all affected test cases.. Ran GHA Sanity Checks (passed), jtreg tier1 tests (passed) and related tests (passed) on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
(Passed) - make test-tier1
(Passed) - make test TEST=test/jdk/java/beans
(Passed) - make test TEST=test/hotspot/jtreg/vmTestbase/gc/g1/unloading
Results are attached.
linux-aarch64-jtreg-tier1.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log
linux-x64-jtreg-tier1.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
macos-aarch64-jtreg-tier1.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
windows-x64-jtreg-tier1.log
windows-x64-specific-test.log
windows-x64-specific-2-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/40/head:pull/40$ git checkout pull/40Update a local copy of the PR:
$ git checkout pull/40$ git pull https://git.openjdk.org/jdk25u-dev.git pull/40/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 40View PR using the GUI difftool:
$ git pr show -t 40Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/40.diff
Using Webrev
Link to Webrev Comment