8363986: Heap region in CDS archive is not at deterministic address#581
8363986: Heap region in CDS archive is not at deterministic address#581GoeLin wants to merge 1 commit into
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
f55302e to
9c73d8c
Compare
|
@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
Webrevs
|
9c73d8c to
09b395a
Compare
|
@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
TheRealMDoerr
left a comment
There was a problem hiding this comment.
LGTM. It's unfortunate that we don't have the refactoring in 25u.
|
|
I backport this for parity with 25.0.4-oracle.
The change needed a row of adaptions. The code touched has been refactored by two
changes before this was applied in head. JDK-8362566 would work nicely in 25, too,
but I don't see need to backport this as prereq.
SAP nghtly testing passes.
Unfortunately the tests don't force enough compressed oop modes, thus only
the tests on mac gave meaningful results, as there a shift is used.
Backporting follow-up jdk-8374712 as dependent PR
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/581/head:pull/581$ git checkout pull/581Update a local copy of the PR:
$ git checkout pull/581$ git pull https://git.openjdk.org/jdk25u-dev.git pull/581/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 581View PR using the GUI difftool:
$ git pr show -t 581Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/581.diff
Using Webrev
Link to Webrev Comment