Skip to content

8369128: ProblemList jdk/jfr/event/profiling/TestCPUTimeSampleQueueAutoSizes.java in Xcomp configs#596

Open
TheRealMDoerr wants to merge 1 commit into
openjdk:masterfrom
TheRealMDoerr:8369133_test_fixes
Open

8369128: ProblemList jdk/jfr/event/profiling/TestCPUTimeSampleQueueAutoSizes.java in Xcomp configs#596
TheRealMDoerr wants to merge 1 commit into
openjdk:masterfrom
TheRealMDoerr:8369133_test_fixes

Conversation

@TheRealMDoerr
Copy link
Copy Markdown
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 5, 2026

Backport of openjdk/jdk@837f634 which consists of 3 test fixes.
I've reverted the change in test/jdk/ProblemList-Xcomp.txt because JDK-8367302 is already backported to 25.0.3 which would remove it from problem list if it was backported in consistent order.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8369128 needs maintainer approval
  • JDK-8369133 needs maintainer approval
  • JDK-8369132 needs maintainer approval

Issues

  • JDK-8369128: ProblemList jdk/jfr/event/profiling/TestCPUTimeSampleQueueAutoSizes.java in Xcomp configs (Sub-task - P4)
  • JDK-8369132: Disable vmTestbase/gc/vector/CircularListLow and LinearListLow with SerialGC (Sub-task - P3)
  • JDK-8369133: Disable gc/g1/TestShrinkAuxiliaryDataRunner.java with UseLargePages option (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/596/head:pull/596
$ git checkout pull/596

Update a local copy of the PR:
$ git checkout pull/596
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/596/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 596

View PR using the GUI difftool:
$ git pr show -t 596

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/596.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Jun 5, 2026

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Jun 5, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 837f634bf29fd877dd62a2e0f7d7a1bd383372d3 8369128: ProblemList jdk/jfr/event/profiling/TestCPUTimeSampleQueueAutoSizes.java in Xcomp configs Jun 5, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Jun 5, 2026

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jun 5, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Jun 5, 2026

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Jun 5, 2026

Webrevs

@TheRealMDoerr
Copy link
Copy Markdown
Contributor Author

/approval request We got test failures when running TestShrinkAuxiliaryDataRunner.java‎ with UseLargePages. Therefore, I want to backport the solution from upstream. The original change fixes 3 issues at once. One of them is a problem list entry which I have reverted because the related fix is already backported (which would remove it from problem list). Now, the backport only adds @requires statements to 3 tests. It has been reviewed and the 3 tests passed.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Jun 5, 2026

@TheRealMDoerr
8369128: The approval request has been created successfully.
8369132: The approval request has been created successfully.
8369133: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Jun 5, 2026
@RealCLanger
Copy link
Copy Markdown
Contributor

Can you please do it in jdk25u because this test noise should rather be fixed in the rampdown branch for 25.0.4.

@TheRealMDoerr
Copy link
Copy Markdown
Contributor Author

Can you please do it in jdk25u because this test noise should rather be fixed in the rampdown branch for 25.0.4.

Makes sense, but needs a review. See linked jdk25u backport.

@openjdk openjdk Bot removed the approval Requires approval; will be removed when approval is received label Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants