-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8240265: iOS: Unnecessary logging on pinch gestures #131
Conversation
👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks trivial.
@jperedadnr This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there has been 1 commit pushed to the As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@johanvos) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@jperedadnr |
/sponsor |
@johanvos @jperedadnr The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit 10c9528. |
Mailing list message from Johan Vos on openjfx-dev: Changeset: 10c9528 8240265: iOS: Unnecessary logging on pinch gestures Reviewed-by: jvos ! modules/javafx.graphics/src/main/java/com/sun/glass/ui/ios/IosGestureSupport.java |
This PR removes unnecessary logging of the scale value during a pinch gesture on iOS
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jfx pull/131/head:pull/131
$ git checkout pull/131