Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8240265: iOS: Unnecessary logging on pinch gestures #131

Closed
wants to merge 1 commit into from

Conversation

jperedadnr
Copy link
Collaborator

@jperedadnr jperedadnr commented Mar 1, 2020

This PR removes unnecessary logging of the scale value during a pinch gesture on iOS


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8240265: iOS: Unnecessary logging on pinch gestures

Reviewers

  • Johan Vos (jvos - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/131/head:pull/131
$ git checkout pull/131

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 1, 2020

👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr Ready for review label Mar 1, 2020
@mlbridge
Copy link

mlbridge bot commented Mar 1, 2020

Webrevs

Copy link
Collaborator

@johanvos johanvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks trivial.

@openjdk
Copy link

openjdk bot commented Mar 2, 2020

@jperedadnr This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8240265: iOS: Unnecessary logging on pinch gestures

Reviewed-by: jvos
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 4c132cdf39282d26bf5e22ded5915d603ec337b7.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@johanvos) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Ready to be integrated label Mar 2, 2020
@jperedadnr
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 2, 2020

@jperedadnr
Your change (at version 2cfa3c7) is now ready to be sponsored by a Committer.

@openjdk openjdk bot added the sponsor Ready to sponsor label Mar 2, 2020
@johanvos
Copy link
Collaborator

johanvos commented Mar 2, 2020

/sponsor

@openjdk openjdk bot closed this Mar 2, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Ready to sponsor ready Ready to be integrated rfr Ready for review labels Mar 2, 2020
@openjdk
Copy link

openjdk bot commented Mar 2, 2020

@johanvos @jperedadnr The following commits have been pushed to master since your change was applied:

  • 4c132cd: 8237889: Update libxml2 to version 2.9.10

Your commit was automatically rebased without conflicts.

Pushed as commit 10c9528.

@mlbridge
Copy link

mlbridge bot commented Mar 2, 2020

Mailing list message from Johan Vos on openjfx-dev:

Changeset: 10c9528
Author: Jose Pereda <jpereda at openjdk.org>
Committer: Johan Vos <jvos at openjdk.org>
Date: 2020-03-02 18:29:15 +0000
URL: https://git.openjdk.java.net/jfx/commit/10c9528e

8240265: iOS: Unnecessary logging on pinch gestures

Reviewed-by: jvos

! modules/javafx.graphics/src/main/java/com/sun/glass/ui/ios/IosGestureSupport.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants