Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264928: Update to Xcode 12.4 #460

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 8, 2021

This updates the compiler used to build JavaFX on macOS to Xcode 12.4 (which includes the MacOSX11.1 sdk), which matches the compiler that will be used to build JDK 17, once openjdk/jdk#3388 is integrated.

As noted in the bug report, Xcode 12.4 needs macOS 10.15.4 (Catalina) or later to build. The produced artifacts will be able to run on earlier versions of macOS (for x86_64 systems anyway).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/460/head:pull/460
$ git checkout pull/460

Update a local copy of the PR:
$ git checkout pull/460
$ git pull https://git.openjdk.java.net/jfx pull/460/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 460

View PR using the GUI difftool:
$ git pr show -t 460

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/460.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 8, 2021

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Apr 8, 2021

/reviewers 2

@kevinrushforth kevinrushforth requested review from arapte and johanvos Apr 8, 2021
@openjdk openjdk bot added the rfr label Apr 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 8, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 8, 2021

Webrevs

@arapte
arapte approved these changes Apr 9, 2021
Copy link
Member

@arapte arapte left a comment

looks good to me. Verified build and sanity test.

Copy link
Collaborator

@johanvos johanvos left a comment

Tested with 12.4, all looking good.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 10, 2021

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264928: Update to Xcode 12.4

Reviewed-by: arapte, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 808b107: 8260245: Update ICU4C to version 68.2
  • d808dd1: 8258663: Fixed size TableCells are not removed from sene graph when column is removed
  • 28475cb: 8263807: Button types of a DialogPane are set twice, returns a wrong button

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 10, 2021
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Apr 12, 2021

/integrate

@openjdk openjdk bot closed this Apr 12, 2021
@openjdk openjdk bot added integrated and removed ready labels Apr 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 12, 2021

@kevinrushforth Since your change was applied there have been 3 commits pushed to the master branch:

  • 808b107: 8260245: Update ICU4C to version 68.2
  • d808dd1: 8258663: Fixed size TableCells are not removed from sene graph when column is removed
  • 28475cb: 8263807: Button types of a DialogPane are set twice, returns a wrong button

Your commit was automatically rebased without conflicts.

Pushed as commit c8384a1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Apr 12, 2021
@kevinrushforth kevinrushforth deleted the kevinrushforth:8264928-Xcode-12.4 branch Apr 12, 2021
@kevinrushforth kevinrushforth mentioned this pull request Apr 12, 2021
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants