8264928: Update to Xcode 12.4#460
Conversation
|
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
|
/reviewers 2 |
|
@kevinrushforth |
arapte
left a comment
There was a problem hiding this comment.
looks good to me. Verified build and sanity test.
johanvos
left a comment
There was a problem hiding this comment.
Tested with 12.4, all looking good.
|
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
@kevinrushforth Since your change was applied there have been 3 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit c8384a1. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This updates the compiler used to build JavaFX on macOS to Xcode 12.4 (which includes the MacOSX11.1 sdk), which matches the compiler that will be used to build JDK 17, once openjdk/jdk#3388 is integrated.
As noted in the bug report, Xcode 12.4 needs macOS 10.15.4 (Catalina) or later to build. The produced artifacts will be able to run on earlier versions of macOS (for x86_64 systems anyway).
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/460/head:pull/460$ git checkout pull/460Update a local copy of the PR:
$ git checkout pull/460$ git pull https://git.openjdk.java.net/jfx pull/460/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 460View PR using the GUI difftool:
$ git pr show -t 460Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/460.diff