-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8267094: TreeCell: cancelEvent must return correct editing location #524
Conversation
👋 Welcome back fastegal! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix looks good to me.
Nicely written tests!
Some of them passed without this fix (you have mentioned this in the PR description) - but, good to have them for covering all scenarios.
@kleopatra This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@kleopatra Since your change was applied there have been 7 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit e6cf1df. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
the bug is an incorrect edit location (for tree: treeItem) in edit cancel events - expected is the location at the time the cell edit was started, actual was the location of at the time the edit was cancelled. See the report for details.
Fixed by storing the edit location in startEdit and use that in cancelEdit.
Added tests that failed before and passed after and tests that (accidentally :) passed before and still pass after.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/524/head:pull/524
$ git checkout pull/524
Update a local copy of the PR:
$ git checkout pull/524
$ git pull https://git.openjdk.java.net/jfx pull/524/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 524
View PR using the GUI difftool:
$ git pr show -t 524
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/524.diff