Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267094: TreeCell: cancelEvent must return correct editing location #524

Closed
wants to merge 2 commits into from

Conversation

@kleopatra
Copy link
Collaborator

@kleopatra kleopatra commented May 28, 2021

the bug is an incorrect edit location (for tree: treeItem) in edit cancel events - expected is the location at the time the cell edit was started, actual was the location of at the time the edit was cancelled. See the report for details.

Fixed by storing the edit location in startEdit and use that in cancelEdit.

Added tests that failed before and passed after and tests that (accidentally :) passed before and still pass after.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267094: TreeCell: cancelEvent must return correct editing location

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/524/head:pull/524
$ git checkout pull/524

Update a local copy of the PR:
$ git checkout pull/524
$ git pull https://git.openjdk.java.net/jfx pull/524/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 524

View PR using the GUI difftool:
$ git pr show -t 524

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/524.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 28, 2021

👋 Welcome back fastegal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 28, 2021

Webrevs

@kevinrushforth kevinrushforth requested a review from aghaisas Jun 4, 2021
Copy link
Collaborator

@aghaisas aghaisas left a comment

Fix looks good to me.

Nicely written tests!
Some of them passed without this fix (you have mentioned this in the PR description) - but, good to have them for covering all scenarios.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@kleopatra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267094: TreeCell: cancelEvent must return correct editing location

Reviewed-by: aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • ca25036: 8267858: Document that title property in WebEngine gets updated asynchronously
  • 59cf4de: 8267505: {List,Set,Map}PropertyBase::bind should check against identity
  • fe81b9c: 8268120: Allow hardware cursor to be used on Monocle-EGL platforms
  • ee03238: 8268152: gstmpegaudioparse does not provides timestamps for HLS MP3 streams
  • 47700d8: 8267819: CoInitialize/CoUninitialize should be called on same thread
  • 526f990: 8239138: StyleManager should use a BufferedInputStream
  • 5e6d442: 8267892: Add .gitattributes to repo

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 10, 2021
@kleopatra
Copy link
Collaborator Author

@kleopatra kleopatra commented Jun 10, 2021

/integrate

@openjdk openjdk bot closed this Jun 10, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@kleopatra Since your change was applied there have been 7 commits pushed to the master branch:

  • ca25036: 8267858: Document that title property in WebEngine gets updated asynchronously
  • 59cf4de: 8267505: {List,Set,Map}PropertyBase::bind should check against identity
  • fe81b9c: 8268120: Allow hardware cursor to be used on Monocle-EGL platforms
  • ee03238: 8268152: gstmpegaudioparse does not provides timestamps for HLS MP3 streams
  • 47700d8: 8267819: CoInitialize/CoUninitialize should be called on same thread
  • 526f990: 8239138: StyleManager should use a BufferedInputStream
  • 5e6d442: 8267892: Add .gitattributes to repo

Your commit was automatically rebased without conflicts.

Pushed as commit e6cf1df.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kleopatra kleopatra deleted the bug-fix-8267094 branch Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants