Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268718: [macos] Video stops, but audio continues to play when stopTime is reached #559

Closed
wants to merge 1 commit into from

Conversation

sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Jul 1, 2021

Not sure why, but our finish() handle was not implemented on OSXPlatform. This handle should pause media stream when called. Also, seek should restart playback when we finish playing video. With proposed fix OSXPlatform will behave same as GSTPlatform. Stop playback when stopTime is reached and resume playback if seek is performed after EndOfMedia or stopTime is reached.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268718: [macos] Video stops, but audio continues to play when stopTime is reached

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/559/head:pull/559
$ git checkout pull/559

Update a local copy of the PR:
$ git checkout pull/559
$ git pull https://git.openjdk.java.net/jfx pull/559/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 559

View PR using the GUI difftool:
$ git pr show -t 559

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/559.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 1, 2021

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 1, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 1, 2021

Webrevs

@kevinrushforth kevinrushforth self-requested a review Jul 2, 2021
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jul 7, 2021

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

This looks good. I can confirm that this fixes the problem. I did notice one small difference remains between GSTPlatform and OSXPlatform. With OSXPlatform, if I advance the media location slider to be after the stop time, the audio sometimes starts playing again. This doesn't happen with GSTPlatform. This seems like a bit of a corner case, though and seems like something that could be handled in a follow-up fix.

@kevinrushforth kevinrushforth requested review from aghaisas and arapte and removed request for aghaisas Jul 7, 2021
arapte
arapte approved these changes Jul 8, 2021
Copy link
Member

@arapte arapte left a comment

Fix looks good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268718: [macos] Video stops, but audio continues to play when stopTime is reached

Reviewed-by: kcr, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 8, 2021
@sashamatveev
Copy link
Member Author

@sashamatveev sashamatveev commented Jul 8, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

Going to push as commit 0c98d96.
Since your change was applied there have been 15 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 8, 2021

@sashamatveev Pushed as commit 0c98d96.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
3 participants