8268718: [macos] Video stops, but audio continues to play when stopTime is reached

[sashamatveev]

Not sure why, but our finish() handle was not implemented on OSXPlatform. This handle should pause media stream when called. Also, seek should restart playback when we finish playing video. With proposed fix OSXPlatform will behave same as GSTPlatform. Stop playback when stopTime is reached and resume playback if seek is performed after EndOfMedia or stopTime is reached.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8268718: [macos] Video stops, but audio continues to play when stopTime is reached

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Ambarish Rapte (@arapte - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/559/head:pull/559
$ git checkout pull/559

Update a local copy of the PR:
$ git checkout pull/559
$ git pull https://git.openjdk.java.net/jfx pull/559/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 559

View PR using the GUI difftool:
$ git pr show -t 559

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/559.diff

[bridgekeeper]

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (f79b6a6c)

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[kevinrushforth]

This looks good. I can confirm that this fixes the problem. I did notice one small difference remains between GSTPlatform and OSXPlatform. With OSXPlatform, if I advance the media location slider to be after the stop time, the audio sometimes starts playing again. This doesn't happen with GSTPlatform. This seems like a bit of a corner case, though and seems like something that could be handled in a follow-up fix.

[arapte]

Fix looks good to me.

[openjdk]

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268718: [macos] Video stops, but audio continues to play when stopTime is reached

Reviewed-by: kcr, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 787506f: 8269597: Change JavaFX release version to 18
• 386f6d7: 8223717: javafx printing: Support Specifying Print to File in the API
• 6fe427f: 8266743: Crash on macOS 10.11 due to ignored @available 10.12 check
• 52c076c: 8269131: Update libxml2 to version 2.9.12
• 47c2ec3: 8187229: Tree/TableCell: cancel event must return correct editing location
• 0e7cf62: 8185447: The special high-contrast mode of JavaFX Controls in Japanese environment do not work.
• 6403d67: 8231558: [macos] Platform.exit causes assertion error on macOS 10.15 or later
• 61aff1c: 8258499: JavaFX: Move src.zip out of the lib directory
• cfa60ff: 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc
• 098c0f3: 8269147: Update GStreamer to version 1.18.4
• ... and 5 more: https://git.openjdk.java.net/jfx/compare/c4cc99882928e423003d54cae0a6b0de2ec05007...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sashamatveev]

/integrate

[openjdk]

Going to push as commit 0c98d96.
Since your change was applied there have been 15 commits pushed to the master branch:

• 787506f: 8269597: Change JavaFX release version to 18
• 386f6d7: 8223717: javafx printing: Support Specifying Print to File in the API
• 6fe427f: 8266743: Crash on macOS 10.11 due to ignored @available 10.12 check
• 52c076c: 8269131: Update libxml2 to version 2.9.12
• 47c2ec3: 8187229: Tree/TableCell: cancel event must return correct editing location
• 0e7cf62: 8185447: The special high-contrast mode of JavaFX Controls in Japanese environment do not work.
• 6403d67: 8231558: [macos] Platform.exit causes assertion error on macOS 10.15 or later
• 61aff1c: 8258499: JavaFX: Move src.zip out of the lib directory
• cfa60ff: 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc
• 098c0f3: 8269147: Update GStreamer to version 1.18.4
• ... and 5 more: https://git.openjdk.java.net/jfx/compare/c4cc99882928e423003d54cae0a6b0de2ec05007...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sashamatveev Pushed as commit 0c98d96.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.