Skip to content

8291906: Bindings.createXxxBinding inherit incorrect method docs #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nlisker wants to merge 1 commit into from
Closed

8291906: Bindings.createXxxBinding inherit incorrect method docs #881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions modules/javafx.base/src/main/java/javafx/beans/binding/Bindings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,11 +161,17 @@ protected boolean computeValue() {
}
}

/**
* Calls {@link BooleanBinding#unbind(Observable...)}.
*/
@Override
public void dispose() {
super.unbind(dependencies);
}

/**
* Returns an immutable list of the dependencies of this binding.
*/
@Override
public ObservableList<?> getDependencies() {
return ((dependencies == null) || (dependencies.length == 0))?
Expand Down Expand Up @@ -201,11 +207,17 @@ protected double computeValue() {
}
}

/**
* Calls {@link DoubleBinding#unbind(Observable...)}.
*/
@Override
public void dispose() {
super.unbind(dependencies);
}

/**
* Returns an immutable list of the dependencies of this binding.
*/
@Override
public ObservableList<?> getDependencies() {
return ((dependencies == null) || (dependencies.length == 0))?
Expand Down Expand Up @@ -241,11 +253,17 @@ protected float computeValue() {
}
}

/**
* Calls {@link FloatBinding#unbind(Observable...)}.
*/
@Override
public void dispose() {
super.unbind(dependencies);
}

/**
* Returns an immutable list of the dependencies of this binding.
*/
@Override
public ObservableList<?> getDependencies() {
return ((dependencies == null) || (dependencies.length == 0))?
Expand Down Expand Up @@ -281,11 +299,17 @@ protected int computeValue() {
}
}

/**
* Calls {@link IntegerBinding#unbind(Observable...)}.
*/
@Override
public void dispose() {
super.unbind(dependencies);
}

/**
* Returns an immutable list of the dependencies of this binding.
*/
@Override
public ObservableList<?> getDependencies() {
return ((dependencies == null) || (dependencies.length == 0))?
Expand Down Expand Up @@ -321,11 +345,17 @@ protected long computeValue() {
}
}

/**
* Calls {@link LongBinding#unbind(Observable...)}.
*/
@Override
public void dispose() {
super.unbind(dependencies);
}

/**
* Returns an immutable list of the dependencies of this binding.
*/
@Override
public ObservableList<?> getDependencies() {
return ((dependencies == null) || (dependencies.length == 0))?
Expand Down Expand Up @@ -362,11 +392,17 @@ protected T computeValue() {
}
}

/**
* Calls {@link ObjectBinding#unbind(Observable...)}.
*/
@Override
public void dispose() {
super.unbind(dependencies);
}

/**
* Returns an immutable list of the dependencies of this binding.
*/
@Override
public ObservableList<?> getDependencies() {
return ((dependencies == null) || (dependencies.length == 0))?
Expand Down Expand Up @@ -402,11 +438,17 @@ protected String computeValue() {
}
}

/**
* Calls {@link StringBinding#unbind(Observable...)}.
*/
@Override
public void dispose() {
super.unbind(dependencies);
}

/**
* Returns an immutable list of the dependencies of this binding.
*/
@Override
public ObservableList<?> getDependencies() {
return ((dependencies == null) || (dependencies.length == 0))?
Expand Down