Skip to content

7133: Update the build script help to include the installCore option#215

Closed
oscerd wants to merge 1 commit intoopenjdk:masterfrom
oscerd:build-build-sh-fix
Closed

7133: Update the build script help to include the installCore option#215
oscerd wants to merge 1 commit intoopenjdk:masterfrom
oscerd:build-build-sh-fix

Conversation

@oscerd
Copy link
Contributor

@oscerd oscerd commented Feb 8, 2021

Noticed this: if you build jmc with build.sh script for the first time, you'll need to run the installCore command first and then all the command listed for testing and packaging it.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7133: Update the build script help to include the installCore option

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jmc pull/215/head:pull/215
$ git checkout pull/215

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 8, 2021

👋 Welcome back oscerd! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@oscerd
Copy link
Contributor Author

oscerd commented Feb 8, 2021

I can't open an issue on JIRA, since I don't have an account currently.

@oscerd oscerd force-pushed the build-build-sh-fix branch from 2a35b41 to edb954e Compare February 8, 2021 09:04
@thegreystone thegreystone changed the title Updated the build instructions in case of build.sh usage 7133: Update the build script help to include the installCore option Feb 8, 2021
@openjdk openjdk bot added the rfr label Feb 8, 2021
@openjdk
Copy link

openjdk bot commented Feb 8, 2021

@oscerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7133: Update the build script help to include the installCore option

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 9381a9a: 6907: Upgrade Jacoco to 0.8.6

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Feb 8, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 8, 2021

Webrevs

@oscerd
Copy link
Contributor Author

oscerd commented Feb 8, 2021

/integrate

@openjdk openjdk bot added the sponsor label Feb 8, 2021
@openjdk
Copy link

openjdk bot commented Feb 8, 2021

@oscerd
Your change (at version edb954e) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

/sponsor

@openjdk openjdk bot closed this Feb 8, 2021
@openjdk
Copy link

openjdk bot commented Feb 8, 2021

@thegreystone @oscerd Since your change was applied there has been 1 commit pushed to the master branch:

  • 9381a9a: 6907: Upgrade Jacoco to 0.8.6

Your commit was automatically rebased without conflicts.

Pushed as commit 77605de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants