8373: Fix tooltip on Flamegraph not showing after switching to Stack Trace view #635

RoiSoleil · 2025-03-28T12:36:55Z

Fix tooltip on Flamegraph not showing after switching to Stack Trace view

The bug : Open a JFR file, open the Flamegraph view, see the tooltip on Flamegraph working, activate the Stack Trace view, get back to Flamegraph ==> the tooltip is not showing anymore on Flamegraph

Progress

Commit message must refer to an issue
Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

JMC-8373: Fix tooltip on Flamegraph not showing after switching to Stack Trace view (Bug - P4)

Reviewers

Brice Dutheil (@bric3 - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/635/head:pull/635
$ git checkout pull/635

Update a local copy of the PR:
$ git checkout pull/635
$ git pull https://git.openjdk.org/jmc.git pull/635/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 635

View PR using the GUI difftool:
$ git pr show -t 635

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/635.diff

Using Webrev

Link to Webrev Comment

…view

bridgekeeper · 2025-03-28T12:37:26Z

👋 Welcome back RoiSoleil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

RoiSoleil · 2025-03-28T12:37:41Z

@aptmac Could you open a ticket ?

openjdk · 2025-03-28T12:37:55Z

@RoiSoleil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373: Fix tooltip on Flamegraph not showing after switching to Stack Trace view

Reviewed-by: bdutheil

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

7510a16: 8366: Jolokia - Display warning when enabling Jolokia discovery about only using the discovery feature in a trusted environment.
da6e38e: 8372: Add UnitLookup.TIMESPAN to AttributeSelection to be able to use the attribute in FlameGraph for IO
6d310d9: 8378: Update version in jcheck conf file
... and 1 more: https://git.openjdk.org/jmc/compare/23fb4f2adc0afab0f008781a8c38ef4332f7744a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@bric3, @aptmac) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

thegreystone · 2025-04-01T23:16:00Z

@aptmac Could you open a ticket ?

Ticket opened.

mlbridge · 2025-04-01T23:18:34Z

Webrevs

00: Full (abb43905)

RoiSoleil · 2025-04-02T07:01:34Z

@aptmac Could you open a ticket ?

Ticket opened.

Thx.

bric3 · 2025-04-02T14:52:16Z

At first glance the changes looks good to me!
About the scenario, is it just moving the mouse from the flamegraph to the click on the stack trace tab. Also, is there an a specific OS where this is happening ?

bric3 · 2025-04-02T14:56:26Z

...graph/src/main/java/org/openjdk/jmc/flightrecorder/flamegraph/views/FlamegraphSwingView.java

 			tooltip.setPopupDelay(500);
 			tooltip.setShift(new Point(10, 5));
-
-			embeddingComposite.addListener(SWT.MouseExit, event -> Display.getDefault().timerExec(300, tooltip::hide));


question: I wonder if this listener is still needed, in case the mouse event is not received on the swing component. E.g. in weird situations like : Alt Tab (on macOs) to change app but in the end selecting back to JMC. Not sure it's a real scenario, but i could imagine the Swing component not properly receiving mouse events.

Without the listener i still have the bug.

RoiSoleil · 2025-04-02T15:47:29Z

At first glance the changes looks good to me!
About the scenario, is it just moving the mouse from the flamegraph to the click on the stack trace tab. Also, is there an a specific OS where this is happening ?

Yes just click on the stack trace on Windows (didn't try on linux or macos).

RoiSoleil · 2025-04-08T09:06:15Z

@bric3 it's ok for you ?

bric3 · 2025-04-08T10:34:49Z

@RoiSoleil I tested on macos this morning. The chat get looks good.

RoiSoleil · 2025-04-08T10:47:40Z

@RoiSoleil I tested on macos this morning. The chat get looks good.

Thx
@aptmac it's ok for you ?

aptmac

LGTM, but I noticed that not all of the usual checks are happening on the PR. IIRC these were enabled in the actions tab of the user's fork, @RoiSoleil could you see if there's anything for you to enabled at: https://github.com/RoiSoleil/jmc/actions ?

RoiSoleil · 2025-04-08T15:27:30Z

On https://github.com/RoiSoleil/jmc/actions :

Workflows aren’t being run on this forked repository
Because this repository contained workflow files when it was forked, we have disabled them from running on this fork. Make sure you understand the configured workflows and their expected usage before enabling Actions on this repository.

RoiSoleil · 2025-04-08T15:27:42Z

/integrate

openjdk · 2025-04-08T15:29:17Z

@RoiSoleil
Your change (at version abb4390) is now ready to be sponsored by a Committer.

RoiSoleil · 2025-04-08T15:30:12Z

/sponsor

openjdk · 2025-04-08T15:30:30Z

@RoiSoleil Only Committers are allowed to sponsor changes.

RoiSoleil · 2025-04-08T15:32:10Z

@aptmac could you sponsor ?

aptmac · 2025-04-08T15:48:31Z

On https://github.com/RoiSoleil/jmc/actions :

Workflows aren’t being run on this forked repository Because this repository contained workflow files when it was forked, we have disabled them from running on this fork. Make sure you understand the configured workflows and their expected usage before enabling Actions on this repository.

Ah, would you be able to try and enable the actions? If the enable option isn't on that page, it may be here: https://github.com/RoiSoleil/jmc/settings/actions

I'm not sure if when enabled Skara will kick off the other actions for this PR, but it would be nice to make sure you're set up for any PRs in the future.

RoiSoleil · 2025-04-08T16:13:51Z

On https://github.com/RoiSoleil/jmc/actions :
Workflows aren’t being run on this forked repository Because this repository contained workflow files when it was forked, we have disabled them from running on this fork. Make sure you understand the configured workflows and their expected usage before enabling Actions on this repository.

Ah, would you be able to try and enable the actions? If the enable option isn't on that page, it may be here: https://github.com/RoiSoleil/jmc/settings/actions

I'm not sure if when enabled Skara will kick off the other actions for this PR, but it would be nice to make sure you're set up for any PRs in the future.

I did it and run validate.yml

aptmac · 2025-04-08T16:23:16Z

On https://github.com/RoiSoleil/jmc/actions :
Workflows aren’t being run on this forked repository Because this repository contained workflow files when it was forked, we have disabled them from running on this fork. Make sure you understand the configured workflows and their expected usage before enabling Actions on this repository.

Ah, would you be able to try and enable the actions? If the enable option isn't on that page, it may be here: https://github.com/RoiSoleil/jmc/settings/actions
I'm not sure if when enabled Skara will kick off the other actions for this PR, but it would be nice to make sure you're set up for any PRs in the future.

I did it and run validate.yml

Great, thanks! I see they are running on the PR, I'll sponsor once the runs complete

aptmac · 2025-04-08T16:37:33Z

/sponsor

openjdk · 2025-04-08T16:38:50Z

Going to push as commit 6a048a8.
Since your change was applied there have been 4 commits pushed to the master branch:

7510a16: 8366: Jolokia - Display warning when enabling Jolokia discovery about only using the discovery feature in a trusted environment.
da6e38e: 8372: Add UnitLookup.TIMESPAN to AttributeSelection to be able to use the attribute in FlameGraph for IO
6d310d9: 8378: Update version in jcheck conf file
... and 1 more: https://git.openjdk.org/jmc/compare/23fb4f2adc0afab0f008781a8c38ef4332f7744a...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-04-08T16:38:58Z

@aptmac @RoiSoleil Pushed as commit 6a048a8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Fix tooltip on Flamegraph not showing after switching to Stack Trace …

abb4390

…view

thegreystone changed the title ~~Fix tooltip on Flamegraph not showing after switching to Stack Trace view~~ 8373: Fix tooltip on Flamegraph not showing after switching to Stack Trace view Apr 1, 2025

openjdk bot added the rfr label Apr 1, 2025

thegreystone requested a review from bric3 April 1, 2025 23:15

thegreystone requested a review from aptmac April 1, 2025 23:16

bric3 reviewed Apr 2, 2025

View reviewed changes

RoiSoleil requested a review from bric3 April 8, 2025 09:14

bric3 approved these changes Apr 8, 2025

View reviewed changes

openjdk bot added the ready label Apr 8, 2025

aptmac reviewed Apr 8, 2025

View reviewed changes

openjdk bot added the sponsor label Apr 8, 2025

openjdk bot added the integrated label Apr 8, 2025

openjdk bot closed this Apr 8, 2025

openjdk bot removed ready rfr sponsor labels Apr 8, 2025

8373: Fix tooltip on Flamegraph not showing after switching to Stack Trace view #635

8373: Fix tooltip on Flamegraph not showing after switching to Stack Trace view #635

Uh oh!

Conversation

RoiSoleil commented Mar 28, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Mar 28, 2025

Uh oh!

RoiSoleil commented Mar 28, 2025

Uh oh!

openjdk bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thegreystone commented Apr 1, 2025

Uh oh!

mlbridge bot commented Apr 1, 2025

Webrevs

Uh oh!

RoiSoleil commented Apr 2, 2025

Uh oh!

bric3 commented Apr 2, 2025

Uh oh!

bric3 Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RoiSoleil Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

RoiSoleil commented Apr 2, 2025

Uh oh!

RoiSoleil commented Apr 8, 2025

Uh oh!

bric3 commented Apr 8, 2025

Uh oh!

RoiSoleil commented Apr 8, 2025

Uh oh!

aptmac left a comment

Choose a reason for hiding this comment

Uh oh!

RoiSoleil commented Apr 8, 2025

Uh oh!

RoiSoleil commented Apr 8, 2025

Uh oh!

openjdk bot commented Apr 8, 2025

Uh oh!

RoiSoleil commented Apr 8, 2025

Uh oh!

openjdk bot commented Apr 8, 2025

Uh oh!

RoiSoleil commented Apr 8, 2025

Uh oh!

aptmac commented Apr 8, 2025

Uh oh!

RoiSoleil commented Apr 8, 2025

Uh oh!

aptmac commented Apr 8, 2025

Uh oh!

aptmac commented Apr 8, 2025

Uh oh!

openjdk bot commented Apr 8, 2025

Uh oh!

openjdk bot commented Apr 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

RoiSoleil commented Mar 28, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Mar 28, 2025 •

edited

Loading

bric3 Apr 2, 2025 •

edited

Loading