Skip to content
This repository has been archived by the owner. It is now read-only.

8260578: Replace wildcard imports with specific ones #161

Closed
wants to merge 1 commit into from

Conversation

aghaisas
Copy link
Collaborator

@aghaisas aghaisas commented Jan 28, 2021

The new files added in Lanai code-base have wildcard imports at several places. Replace them with specific import statements.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8260578: Replace wildcard imports with specific ones

Download

$ git fetch https://git.openjdk.java.net/lanai pull/161/head:pull/161
$ git checkout pull/161

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 28, 2021

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 28, 2021

@aghaisas This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260578: Replace wildcard imports with specific ones

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jan 28, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 28, 2021

Webrevs

@aghaisas
Copy link
Collaborator Author

aghaisas commented Jan 28, 2021

I have replaced all wildcard imports from newly added files except below 3 files.

src/java.desktop/macosx/classes/sun/java2d/metal/MTLMaskFill.java
src/java.desktop/macosx/classes/sun/java2d/metal/MTLMaskBlit.java
src/java.desktop/macosx/classes/sun/java2d/metal/MTLGraphicsConfig.java

I found that in above files, replacing individual static imports for constants/objects will unnecessarily bloat the source. In this case it is better to use wildcard imports.

@aghaisas
Copy link
Collaborator Author

aghaisas commented Jan 28, 2021

/integrate

@openjdk openjdk bot closed this Jan 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 28, 2021
@openjdk
Copy link

openjdk bot commented Jan 28, 2021

@aghaisas Pushed as commit 24f0d2a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated
1 participant