8368497: [lworld] redo: New lint category initialization for code that would not be allowed in the prologue

[vicente-romero-oracle]

redoing JDK-8367698 as the original fix had to be delta applied due to some test failures

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8368497: [lworld] redo: New lint category initialization for code that would not be allowed in the prologue (Bug - P4)

Reviewers

• Chen Liang (@liach - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1650/head:pull/1650
$ git checkout pull/1650

Update a local copy of the PR:
$ git checkout pull/1650
$ git pull https://git.openjdk.org/valhalla.git pull/1650/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1650

View PR using the GUI difftool:
$ git pr show -t 1650

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1650.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368497: [lworld] redo: New lint category `initialization` for code that would not be allowed in the prologue

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the lworld branch:

• a687d94: 8369044: [lworld] Interpreter does not emit barrier at the end of java.lang.Object::
• 2abd3a9: 8367242: [lworld] C2 compilation asserts with "dead loop detected"
• 2bc50b3: 8367767: [lworld] Interpreter adherence to new memory model rules for strict instance fields

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 06: Full - Incremental (f1af2abc)
• 05: Full - Incremental (4878eea3)
• 04: Full - Incremental (3c7b8d9b)
• 03: Full - Incremental (2b7e6817)
• 02: Full - Incremental (bc40ec8b)
• 01: Full - Incremental (4af18367)
• 00: Full (4865c380)

[liach]

Can we put all these @modules into TEST.properties like this: https://github.com/openjdk/jdk/blob/db6320df980ebe7cf2a1c727970cc937ab549b97/test/jdk/jdk/classfile/TEST.properties#L2-L5

[liach]

Can we just do baseDir.resolve(className + ".java"), and do a Files.exists check for the golden file, instead of having complicated stuf like this?

[vicente-romero-oracle]

yep I wanted to clean that before pushing but then I forgot, thanks

[liach]

Instead of patching individual microbenchmarks, we should just include initialization here:

valhalla/make/test/BuildMicrobenchmark.gmk

Lines 86 to 87 in 2bc50b3

	DISABLED_WARNINGS := restricted this-escape processing rawtypes removal cast \
	serial preview unchecked deprecation dangling-doc-comments, \

[liach]

We should probably ignore initialization warnings for test libs at:

valhalla/make/test/BuildTestLib.gmk

Line 65 in 2bc50b3

DISABLED_WARNINGS := try deprecation rawtypes unchecked serial cast removal preview restricted varargs dangling-doc-comments, \

[vicente-romero-oracle]

yes we could, but I prefer not to. I found bugs in the original implementation by analyzing case by case the reason for the warnings. If we remove it for all tests then we could be blinded to lwrking bugs

[liach]

Looks good for pushing

[vicente-romero-oracle]

/integrate

[vicente-romero-oracle]

@liach thanks for the comments

[openjdk]

Going to push as commit 1a33b86.
Since your change was applied there have been 3 commits pushed to the lworld branch:

• a687d94: 8369044: [lworld] Interpreter does not emit barrier at the end of java.lang.Object::
• 2abd3a9: 8367242: [lworld] C2 compilation asserts with "dead loop detected"
• 2bc50b3: 8367767: [lworld] Interpreter adherence to new memory model rules for strict instance fields

Your commit was automatically rebased without conflicts.

[openjdk]

@vicente-romero-oracle Pushed as commit 1a33b86.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.