8371356: [lworld] 'super' should be rejected in early construction context

[vicente-romero-oracle]

There is a bug in the algo to determine what is kosher and what is not in early construction contexts. The algo was not analyzing any static symbol. But according to the JLS 25 15.11.2 Accessing Superclass Members using super:

It is a compile-time error if a field access expression using the keyword super
occurs in a static context (§8.1.3) or in an early construction context (§8.8.7) of
the current class.

the previous code was checking this only for instance field accesses. The current fix corrects this bug

TIA

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8371356: [lworld] 'super' should be rejected in early construction context (Bug - P4)

Reviewers

• Chen Liang (@liach - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1740/head:pull/1740
$ git checkout pull/1740

Update a local copy of the PR:
$ git checkout pull/1740
$ git pull https://git.openjdk.org/valhalla.git pull/1740/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1740

View PR using the GUI difftool:
$ git pr show -t 1740

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1740.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371356: [lworld] 'super' should be rejected in early construction context

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the lworld branch:

• fe178a8: 8364447: [lworld] Save isIdentity in a field of Class
• 63a6221: 8371897: [lworld] CLONE - VerifyJimage test incorrectly skips all tests when comparing directory structure

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (c39509ad)

[liach]

Should the test also use Parent.super.check and Medium.super.check?

[vicente-romero-oracle]

in those cases javac already fails with:

error: not an enclosing class: ClassName

[liach]

I remember the original case provided uses Interface.super.staticField. So it's like we have this code in Medium instead; can we maybe make Inner9Test instead of Medium implement Parent?

[vicente-romero-oracle]

I couldn't reproduce the error with the original example in javac, the original example was tested on jshell, but when then the reporter went back to the original java code for which this issue was happening and the case in the JBS was the minimal standalone reproductor for the issue. Dunno what is the interaction with jshell that makes the difference though

[vicente-romero-oracle]

/integrate

[openjdk]

Going to push as commit e50f031.
Since your change was applied there have been 2 commits pushed to the lworld branch:

• fe178a8: 8364447: [lworld] Save isIdentity in a field of Class
• 63a6221: 8371897: [lworld] CLONE - VerifyJimage test incorrectly skips all tests when comparing directory structure

Your commit was automatically rebased without conflicts.

[openjdk]

@vicente-romero-oracle Pushed as commit e50f031.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.