8374887: [lworld] Cleanup around vgetfield/vputfield for x86

[jsikstro]

Hello,

This is a follow up from JDK-8374093 cleaning up the x86 implementation as well.

Testing:

• hotspot_valhalla and jdk_valhalla on x86-64

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8374887: [lworld] Cleanup around vgetfield/vputfield for x86 (Enhancement - P4)

Reviewers

• Frederic Parain (@fparain - Committer)
• Paul Hübner (@Arraying - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1875/head:pull/1875
$ git checkout pull/1875

Update a local copy of the PR:
$ git checkout pull/1875
$ git pull https://git.openjdk.org/valhalla.git pull/1875/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1875

View PR using the GUI difftool:
$ git pr show -t 1875

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1875.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jsikstro This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374887: [lworld] Cleanup around vgetfield/vputfield for x86

Reviewed-by: fparain, phubner

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

• ab311a7: 8374913: [lworld] UnProblemList three tests due to JDK-8372341

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@fparain, @Arraying) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (4699972a)

[fparain]

LGTM

[Arraying]

Thank you!

[jsikstro]

Thank you for the reviews @fparain and @Arraying!
/integrate

[openjdk]

@jsikstro
Your change (at version 4699972) is now ready to be sponsored by a Committer.

[fparain]

/sponsor

[openjdk]

Going to push as commit 1ecc74b.
Since your change was applied there has been 1 commit pushed to the lworld branch:

• ab311a7: 8374913: [lworld] UnProblemList three tests due to JDK-8372341

Your commit was automatically rebased without conflicts.

[openjdk]

@fparain @jsikstro Pushed as commit 1ecc74b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.