Provide getting started document for VS Code #214
Conversation
Signed-off-by: sheche <sheche@microsoft.com>
|
Hi @jperedadnr, This is the PR to initialize the getting started document for VS Code. One question: I noticed that the existing screenshots all have a white colored margin as the background, the screenshots in this PR does not have that, do I need to add them? Or could I directly use css margin style? |
|
@jperedadnr would you mind to take a look at this PR? |
|
Ok, we'll look into it. |
|
Hi @jperedadnr, We post a tweet on Twitter yesterday about JavaFX support in VS Code, looks like people are really existing about JavaFX support in VS Code. The tweet's PV data looks amazing too:
It would be really appreciated if the team can get this PR reviewed and merged, which I think can provide more help to the JavaFX and VS Code developers. 😄 |
|
The screenshots are very close to the paragraph text.
Adding the following style to
|
|
|
||
| <a href="images/ide/vscode/gradle/vscode05.png" target="_blank"><img src="images/ide/vscode/gradle/vscode05.png" alt="Gradle dependencies"/></a> | ||
|
|
||
| As for any other Gradle dependencies, these jars can be found in the local <kbd>.gradle</kbd> repository. |
There was a problem hiding this comment.
I don't get this statement. What other Gradle dependencies are we referring to?
There was a problem hiding this comment.
I copied this from the Eclipse tutorial, see:
Non-modular with Maven>2. Verify the pomNon-modular with Gradle>2. Modify the build
I guess it intends to tell the readers that the build tool will manage all the dependencies from different projects into those folders?
I agree that this statement somehow introduces confusions and I'm ok to remove it.
There was a problem hiding this comment.
In that case I would keep these as it is and update the sentences for all IDE together in a later PR.
|
|
||
| <a href="images/ide/vscode/maven/vscode04.png" target="_blank"><img src="images/ide/vscode/maven/vscode04.png" alt="Update the pom"/></a> | ||
|
|
||
| As for any other maven dependencies, these jars can be found in the local <kbd>.m2</kbd> repository. |
There was a problem hiding this comment.
I don't get this statement. What other Maven dependencies are we referring to?
|
|
||
| <a href="images/ide/vscode/modular/maven/vscode04.png" target="_blank"><img src="images/ide/vscode/modular/maven/vscode04.png" alt="Update the pom"/></a> | ||
|
|
||
| As for any other maven dependencies, these jars can be found in the local <kbd>.m2</kbd> repository. |
There was a problem hiding this comment.
I don't get this statement. What other Maven dependencies are we referring to?
|
|
||
| <a href="images/ide/vscode/modular/gradle/vscode05.png" target="_blank"><img src="images/ide/vscode/modular/gradle/vscode05.png" alt="Gradle dependencies"/></a> | ||
|
|
||
| As for any other Gradle dependencies, these jars can be found in the local <kbd>.gradle</kbd> repository. |
There was a problem hiding this comment.
I don't get this statement. What other Gradle dependencies are we referring to?
- fix the css style - refine the wording Signed-off-by: sheche <sheche@microsoft.com>
|
@abhinayagarwal Thank you for reviewing the PR. I've addressed some of the comments. As of the statements of Waiting for your suggestion and I'll make follow-up actions if needs. |
3 participants
Signed-off-by: sheche sheche@microsoft.com