Skip to content

feat(workspace): add ports field to WorkspaceConfiguration#60

Merged
benoitf merged 1 commit into
openkaiden:mainfrom
feloy:workspace-ports
May 5, 2026
Merged

feat(workspace): add ports field to WorkspaceConfiguration#60
benoitf merged 1 commit into
openkaiden:mainfrom
feloy:workspace-ports

Conversation

@feloy
Copy link
Copy Markdown
Contributor

@feloy feloy commented May 5, 2026

Allows users to specify a list of TCP port numbers to expose from the workspace, alongside the existing network and environment configuration.

Related to openkaiden/kdn#385

@feloy feloy requested review from benoitf and jeffmaury May 5, 2026 13:48
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

Warning

Rate limit exceeded

@feloy has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 55 minutes and 20 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8556c320-f5f3-4ef4-b305-df7a4b960777

📥 Commits

Reviewing files that changed from the base of the PR and between ea220ef and 33ad282.

📒 Files selected for processing (1)
  • workspace-configuration/openapi.yaml
📝 Walkthrough

Walkthrough

A single OpenAPI schema definition for WorkspaceConfiguration is updated to add a new ports array field under the network configuration object, specifying TCP ports to expose. The example response is updated to demonstrate the new field alongside existing network configuration.

Changes

Network Ports Configuration

Layer / File(s) Summary
Schema Definition
workspace-configuration/openapi.yaml
network.ports property added to WorkspaceConfiguration schema as an array of integers with description "List of TCP ports to expose from the workspace."
Example Documentation
workspace-configuration/openapi.yaml
GET / response example updated to include ports: [8080, 5432] in the network section with mode: "deny".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • openkaiden/kdn-api#39: Introduced the initial WorkspaceConfiguration.network schema; this PR extends it with the new ports array field.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding a ports field to the WorkspaceConfiguration schema.
Description check ✅ Passed The description is directly related to the changeset, explaining what the new ports field enables and providing context with an issue reference.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@workspace-configuration/openapi.yaml`:
- Around line 87-91: The ports array schema currently allows any integer so
invalid TCP ports (0, negatives, >65535) can be accepted; update the ports ->
items schema to add minimum: 1 and maximum: 65535 and set uniqueItems: true on
the ports array to reject duplicates; modify the existing ports definition (the
ports property and its items schema) to include these constraints so validation
enforces valid TCP port ranges and uniqueness.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2f35ec97-4c6e-4984-8a25-22167a3c9b50

📥 Commits

Reviewing files that changed from the base of the PR and between 002d325 and ea220ef.

📒 Files selected for processing (1)
  • workspace-configuration/openapi.yaml

Comment thread workspace-configuration/openapi.yaml
Allows users to specify a list of TCP port numbers to expose from
the workspace, alongside the existing network and environment
configuration.

Co-Authored-By: Claude Code (claude-sonnet-4-6) <noreply@anthropic.com>
Signed-off-by: Philippe Martin <phmartin@redhat.com>
@feloy feloy force-pushed the workspace-ports branch from ea220ef to 33ad282 Compare May 5, 2026 13:51
Copy link
Copy Markdown

@slemeur slemeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@benoitf benoitf merged commit 5e96045 into openkaiden:main May 5, 2026
3 checks passed
Copy link
Copy Markdown
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we also need to plan how to get the local ports once workspace is started or did I miss something (CL API ?)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants