Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughRenames the CLI binary and all user-facing references from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
cmd/kdn/main_test.go (1)
26-32:⚠️ Potential issue | 🟡 MinorAdd
t.Parallel()as the first line of this test.This touched test does not currently satisfy the test parallelization rule.
Suggested patch
func TestMain_VersionSubcommand(t *testing.T) { + t.Parallel() + // Save original os.Args and restore after test oldArgs := os.Args defer func() { os.Args = oldArgs }()As per coding guidelines,
**/*_test.go: “All tests must callt.Parallel()as the first line of the test function, except tests usingt.Setenv()which cannot uset.Parallel()on the parent test function”.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@cmd/kdn/main_test.go` around lines 26 - 32, The TestMain_VersionSubcommand test must call t.Parallel() as its first statement; edit the TestMain_VersionSubcommand function to insert t.Parallel() immediately after the function opening (before saving/restoring os.Args and before any calls to t.Setenv(), etc.) so the test runs under the test parallelization rule.pkg/cmd/workspace.go (1)
25-31:⚠️ Potential issue | 🟠 MajorPlease add an
Examplesection (and matching examples test) toworkspacecommand.This command currently has
Argsbut noExamplefield in its Cobra definition.As per coding guidelines:
pkg/cmd/*.go: “All Go commands must include anExamplefield with usage examples and have a correspondingTest<Command>Cmd_Examplestest function”.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pkg/cmd/workspace.go` around lines 25 - 31, Add an Example string to the Cobra command returned by NewWorkspaceCmd (set the Command.Example field with one or more usage lines demonstrating common usage of the "workspace" command) and add a matching test named TestWorkspaceCmd_Examples that verifies the Example is present and validates the examples (e.g., asserts command.Example is non-empty and/or runs any example snippets as appropriate for your test harness). Update NewWorkspaceCmd to include the Example field and create the TestWorkspaceCmd_Examples test function in the package tests to satisfy the coding guideline.
🧹 Nitpick comments (1)
pkg/cmd/helpers.go (1)
45-47: Avoid hardcodingkdnin alias adaptation guard.This helper is now coupled to one executable name. It will silently stop adapting examples if the binary prefix changes again or if command lines are formatted differently.
Suggested patch
- // Only replace in command lines (starting with kdn), not in comments - if strings.HasPrefix(trimmed, "kdn ") { + // Replace only in non-comment command lines that contain the original command fragment. + if !strings.HasPrefix(trimmed, "#") && strings.Contains(trimmed, " "+originalCmd) { line = strings.Replace(line, originalCmd, aliasCmd, 1) }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pkg/cmd/helpers.go` around lines 45 - 47, The guard currently hardcodes "kdn" which breaks adaptation if the binary name or formatting changes; update the condition to detect the actual command prefix dynamically (e.g., use strings.HasPrefix(trimmed, originalCmd+" ") and also check the base executable name via path.Base(originalCmd)+ " " to handle paths) before calling strings.Replace; modify the code around the existing check that uses trimmed, originalCmd and aliasCmd so it no longer relies on the literal "kdn" string.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pkg/cmd/version.go`:
- Around line 26-34: NewVersionCmd is missing an Example usage string and the
corresponding example test; add an Example field to the returned *cobra.Command
in NewVersionCmd() (showing typical usage like "kdn version" and expected
output) and add a test named TestVersionCmd_Examples that exercises the examples
using testing.Example or verifies the Example output; ensure the Example text is
realistic, formatted exactly as shown in help, and the test asserts the example
runs without failure.
---
Outside diff comments:
In `@cmd/kdn/main_test.go`:
- Around line 26-32: The TestMain_VersionSubcommand test must call t.Parallel()
as its first statement; edit the TestMain_VersionSubcommand function to insert
t.Parallel() immediately after the function opening (before saving/restoring
os.Args and before any calls to t.Setenv(), etc.) so the test runs under the
test parallelization rule.
In `@pkg/cmd/workspace.go`:
- Around line 25-31: Add an Example string to the Cobra command returned by
NewWorkspaceCmd (set the Command.Example field with one or more usage lines
demonstrating common usage of the "workspace" command) and add a matching test
named TestWorkspaceCmd_Examples that verifies the Example is present and
validates the examples (e.g., asserts command.Example is non-empty and/or runs
any example snippets as appropriate for your test harness). Update
NewWorkspaceCmd to include the Example field and create the
TestWorkspaceCmd_Examples test function in the package tests to satisfy the
coding guideline.
---
Nitpick comments:
In `@pkg/cmd/helpers.go`:
- Around line 45-47: The guard currently hardcodes "kdn" which breaks adaptation
if the binary name or formatting changes; update the condition to detect the
actual command prefix dynamically (e.g., use strings.HasPrefix(trimmed,
originalCmd+" ") and also check the base executable name via
path.Base(originalCmd)+ " " to handle paths) before calling strings.Replace;
modify the code around the existing check that uses trimmed, originalCmd and
aliasCmd so it no longer relies on the literal "kdn" string.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c17e0dd0-bab2-4c0e-8a7c-5bcbc71fee79
📒 Files selected for processing (21)
.gitignore.goreleaser.yamlMakefilecmd/kdn/main.gocmd/kdn/main_test.gopkg/cmd/helpers.gopkg/cmd/helpers_test.gopkg/cmd/info.gopkg/cmd/init.gopkg/cmd/root.gopkg/cmd/root_test.gopkg/cmd/terminal_test.gopkg/cmd/testutil/example_validator.gopkg/cmd/testutil/example_validator_test.gopkg/cmd/version.gopkg/cmd/workspace.gopkg/cmd/workspace_list.gopkg/cmd/workspace_remove.gopkg/cmd/workspace_start.gopkg/cmd/workspace_stop.gopkg/cmd/workspace_terminal.go
benoitf
approved these changes
Apr 8, 2026
Signed-off-by: Philippe Martin <phmartin@redhat.com>
Signed-off-by: Philippe Martin <phmartin@redhat.com>
Signed-off-by: Philippe Martin <phmartin@redhat.com>
Signed-off-by: Philippe Martin <phmartin@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #193