feat: add label configuration and validation for key specs#126
Merged
Conversation
jithinkunjachan
force-pushed
the
feat/labelconfiguration
branch
from
1080f66 to
0f3354e
Compare
apatsap
approved these changes
Apr 30, 2026
jithinkunjachan
force-pushed
the
feat/labelconfiguration
branch
3 times, most recently
from
89daa97 to
b318a52
Compare
fabenan-f
approved these changes
May 6, 2026
Introduce LabelSpec, LabelRequirement, and LabelValidator types to support configurable label validation (regex and enum) on key hierarchy specs. Each KeySpec now carries a LabelSpec that is validated as part of the hierarchy configuration.
…tion tags Rename Labels to SelectorLabels and LabelSpec to LabelSpecs, convert YAML tags to snake_case, remove Labels from KeyBinding, and use model.Labels in label validation. # Conflicts: # internal/config/config_test.go # Conflicts: # pkg/api/agents/deregister_test.go # pkg/api/agents/heartbeat_test.go # pkg/api/agents/register_test.go # Conflicts: # internal/config/config.go
jithinkunjachan
force-pushed
the
feat/labelconfiguration
branch
from
6255a4e to
b50f033
Compare
fabenan-f
approved these changes
May 7, 2026
jithinkunjachan
force-pushed
the
feat/labelconfiguration
branch
from
b50f033 to
3e14e8c
Compare
fabenan-f
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce LabelSpec, LabelRequirement, and LabelValidator types to support configurable label validation (regex and enum) on key hierarchy specs. Each KeySpec now carries a LabelSpec that is validated as part of the hierarchy configuration.