Skip to content

chore: adopt new oidc package#232

Merged
cb80 merged 2 commits intomainfrom
openid
Mar 4, 2026
Merged

chore: adopt new oidc package#232
cb80 merged 2 commits intomainfrom
openid

Conversation

@cb80
Copy link
Copy Markdown
Contributor

@cb80 cb80 commented Feb 10, 2026

This PR:

  • adopts the new oidc package from common-sdk
  • caches the well known OpenID configuration
  • caches the token introspection result

Copy link
Copy Markdown

@hyperspace-insights hyperspace-insights Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request introduces caching for OIDC configurations and token introspection results, but has several critical security and reliability issues that should be addressed before merging.

PR Bot Information

Version: 1.17.86 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

  • Correlation ID: a1560e90-16fb-11f1-999d-9086a297cb04
  • LLM: anthropic--claude-4.5-sonnet
  • Event Trigger: issue_comment.created

Comment thread internal/grpc/session.go
Comment thread internal/session/openid.go
Comment thread internal/grpc/session.go
Comment thread internal/grpc/session.go Outdated
Comment thread internal/session/openid.go Outdated
@hyperspace-insights hyperspace-insights Bot deleted a comment from cb80 Mar 3, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 3, 2026

@hyperspace-insights hyperspace-insights Bot deleted a comment from cb80 Mar 3, 2026
@cb80 cb80 changed the title chore: adopt new openid package chore: adopt new oidc package Mar 3, 2026
@cb80 cb80 marked this pull request as ready for review March 3, 2026 13:37
@cb80 cb80 merged commit e0bf99c into main Mar 4, 2026
6 checks passed
@cb80 cb80 deleted the openid branch March 4, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants