[Feature] Refactor some code to improve extensibility#83
Conversation
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #83 +/- ##
==========================================
- Coverage 46.89% 46.53% -0.36%
==========================================
Files 77 78 +1
Lines 4506 4493 -13
==========================================
- Hits 2113 2091 -22
- Misses 2198 2208 +10
+ Partials 195 194 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| agentsv1alpha1 "github.com/openkruise/agents/api/v1alpha1" | ||
| "github.com/openkruise/agents/pkg/proxy" | ||
| stateutils "github.com/openkruise/agents/pkg/utils/sandboxutils" | ||
| "k8s.io/klog/v2" |
There was a problem hiding this comment.
plz move third party dependency before repository local dependency
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews