Skip to content

[Feature] Refactor some code to improve extensibility#83

Merged
furykerry merged 2 commits intoopenkruise:masterfrom
AiRanthem:feature/enhance-extensibility-260113
Jan 14, 2026
Merged

[Feature] Refactor some code to improve extensibility#83
furykerry merged 2 commits intoopenkruise:masterfrom
AiRanthem:feature/enhance-extensibility-260113

Conversation

@AiRanthem
Copy link
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
Signed-off-by: AiRanthem <zhongtianyun.zty@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 39.62264% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.53%. Comparing base (d7833f5) to head (bea5984).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/utils/sandbox-manager/proxyutils/default.go 0.00% 19 Missing ⚠️
pkg/sandbox-manager/clients/client.go 0.00% 4 Missing ⚠️
pkg/servers/e2b/sandbox.go 0.00% 3 Missing ⚠️
pkg/utils/sandbox-manager/proxyutils/utils.go 80.00% 2 Missing and 1 partial ⚠️
pkg/sandbox-manager/infra/sandboxcr/sandbox.go 33.33% 2 Missing ⚠️
pkg/servers/e2b/services.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   46.89%   46.53%   -0.36%     
==========================================
  Files          77       78       +1     
  Lines        4506     4493      -13     
==========================================
- Hits         2113     2091      -22     
- Misses       2198     2208      +10     
+ Partials      195      194       -1     
Flag Coverage Δ
unittests 46.53% <39.62%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

agentsv1alpha1 "github.com/openkruise/agents/api/v1alpha1"
"github.com/openkruise/agents/pkg/proxy"
stateutils "github.com/openkruise/agents/pkg/utils/sandboxutils"
"k8s.io/klog/v2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz move third party dependency before repository local dependency

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@furykerry furykerry merged commit 6d65f97 into openkruise:master Jan 14, 2026
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants