docs(config): drop stale graph_types_enabled gate reference (Phase 8 #65)#275
Merged
charlie83Gs merged 1 commit intomainfrom Apr 20, 2026
Merged
docs(config): drop stale graph_types_enabled gate reference (Phase 8 #65)#275charlie83Gs merged 1 commit intomainfrom
charlie83Gs merged 1 commit intomainfrom
Conversation
) The planned global ``graph_types_enabled`` kill-switch in ``Settings`` was not needed: per-phase plugins gate themselves via their own ``is_enabled()`` feature flags (``plugin.fetchers.enabled``, ``plugin.concept_extractor.enabled``, etc.), and workers resolve providers through the plugin registry with fallback to the deprecated flat ``Settings`` path (layer 5 of the resolver) when no contribution covers an id. Update the ``graphs:`` section comment in ``config.yaml`` to reflect what actually ships — the section is always read when present, and operators control rollout per-plugin rather than via a global boolean. No code change; the flag was never added to ``Settings``. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the `config.yaml` comment on the `graphs:` section to remove the reference to a `graph_types_enabled` global flag that was never added to `Settings`. Per-phase plugins gate themselves via their own `is_enabled()` feature flags (`plugin.fetchers.enabled`, `plugin.concept_extractor.enabled`, etc.) — there's no global kill-switch to flip.
Why
#65 originally scoped as "flip `graph_types_enabled=true`". In practice the rollout strategy shipped per-phase (Phases 1–3 + 7 + 8 are live as-of #272/#273/#274/earlier), so the global gate was never needed. The stale comment was misleading operators into looking for a flag that doesn't exist.
Test plan
Comment-only change. No code touched, no tests affected.
🤖 Generated with Claude Code