Change text string to be translated to UTF-8 encoding. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dictionary to UTF-8 encoding. Conversion is needed to allow Japanese strings to be passed to urlencode().
sharoonthomas
pushed a commit
that referenced
this pull request
Jul 16, 2011
Change text string to be translated to UTF-8 encoding.
Contributor
|
Thank you for your contribution. |
Contributor
Author
|
You're welcome. Thank you for your great tool! :-) Maceo On Sat, Jul 16, 2011 at 9:56 AM, sharoonthomas <
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
translate()function, I changed text to be translated in the parameters dictionary to UTF-8 encoding. I needed this to allow Japanese strings to be translated. Otherwise,urlencode()in thecall()function would fail with a UnicodeEncode exception.This change does not have any affect on legacy ASCII strings.